Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Count expressions within execs in SqlPlanParser #1447

Closed
amahussein opened this issue Dec 5, 2024 · 0 comments · Fixed by #1449
Closed

[BUG] Count expressions within execs in SqlPlanParser #1447

amahussein opened this issue Dec 5, 2024 · 0 comments · Fixed by #1449
Assignees
@amahussein
Labels
bug Something isn't working core_tools Scope the core module (scala)

Comments

@amahussein
Copy link
Collaborator

Describe the bug

Following #1444 , we need to update the parser classes to count the occurrences of each expression within a given exec.
This will make the operators stats more accurate.
@amahussein amahussein added ? - Needs Triage bug Something isn't working core_tools Scope the core module (scala) labels Dec 5, 2024
@amahussein amahussein self-assigned this Dec 5, 2024
amahussein added a commit to amahussein/spark-rapids-tools that referenced this issue Dec 5, 2024
@amahussein
Count expressions per Exec in SQLPlanParser
1fba881 
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>

Fixes NVIDIA#1447

Improves the operators-stats by counting the occurence of each
expression within the Exec node.
amahussein added a commit to amahussein/spark-rapids-tools that referenced this issue Dec 5, 2024
@amahussein
Count expressions per Exec in SQLPlanParser
c15aac9 
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>

Fixes NVIDIA#1447

Improves the operators-stats by counting the occurence of each
expression within the Exec node.
@amahussein amahussein mentioned this issue Dec 5, 2024
Merged
@nartal1 nartal1 closed this as completed in ab4cf6a Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amahussein amahussein

Labels
bug Something isn't working core_tools Scope the core module (scala)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Count expressions per Exec in SQLPlanParser amahussein/spark-rapids-tools
1 participant
@amahussein