Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Better way to build/run cudf native tests #980

Closed
revans2 opened this issue Feb 28, 2023 · 2 comments
Closed

[FEA] Better way to build/run cudf native tests #980

revans2 opened this issue Feb 28, 2023 · 2 comments
Assignees
Labels

Comments

@revans2
Copy link
Collaborator

revans2 commented Feb 28, 2023

Is your feature request related to a problem? Please describe.
A lot of developers don't build/run in CUDF directly any more. It is all done through spark-rapids-jni. This becomes a problem when we find a bug in CUDF and try to create a C++ test to reproduce the error. It would really be great if there were a simple way to build/run the c++ tests in thirdparty/cudf in addition to the C++ tests that we can run from spark-rapids-jni. I don't think we need to do this by default. But it would make developing these tests a lot simpler.

@jlowe
Copy link
Member

jlowe commented Feb 28, 2023

This should be relatively straightforward. We're hardcoding BUILD_TESTS=OFF in build-libcudf.xml, and it's straightforward to make this a parameterized setting based on a Maven property passed down to the Ant execution. If the existing install target just builds the tests and doesn't run them, then we would need to add a step to run the tests (which could be a separate, conditional antrun execution in the main pom).

@jlowe
Copy link
Member

jlowe commented Dec 23, 2024

Since #2115 it's easy to build libcudf tests and benchmarks from a spark-rapids-jni build by specifying -DBUILD_CUDF_TESTS=ON and -DBUILD_CUDF_BENCHMARKS=ON, respectively.

@jlowe jlowe closed this as completed Dec 23, 2024
@gerashegalov gerashegalov self-assigned this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants