Skip to content

Commit 163c673

Browse files
author
jenkins
committed
Merge branch-24.04 into main
2 parents 298fe9f + c0003fa commit 163c673

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

66 files changed

+8239
-217
lines changed

.github/workflows/add-to-project.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright (c) 2022-2023, NVIDIA CORPORATION.
1+
# Copyright (c) 2022-2024, NVIDIA CORPORATION.
22
#
33
# Licensed under the Apache License, Version 2.0 (the "License");
44
# you may not use this file except in compliance with the License.
@@ -28,7 +28,7 @@ jobs:
2828
name: Add new issues and pull requests to project
2929
runs-on: ubuntu-latest
3030
steps:
31-
- uses: actions/add-to-project@v0.4.0
31+
- uses: actions/add-to-project@v0.6.1
3232
with:
3333
project-url: https://github.com/orgs/NVIDIA/projects/4
3434
github-token: ${{ secrets.PROJECT_TOKEN }}

.github/workflows/auto-merge.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,20 +18,20 @@ name: auto-merge HEAD to BASE
1818
on:
1919
pull_request_target:
2020
branches:
21-
- branch-24.02
21+
- branch-24.04
2222
types: [closed]
2323

2424
env:
25-
HEAD: branch-24.02
26-
BASE: branch-24.04
25+
HEAD: branch-24.04
26+
BASE: branch-24.06
2727

2828
jobs:
2929
auto-merge:
3030
if: github.event.pull_request.merged == true
3131
runs-on: ubuntu-latest
3232

3333
steps:
34-
- uses: actions/checkout@v3
34+
- uses: actions/checkout@v4
3535
with:
3636
ref: ${{ env.HEAD }} # force to fetch from latest upstream instead of PR ref
3737
token: ${{ secrets.AUTOMERGE_TOKEN }} # workaround auto-merge token to avoid GITHUB_TOKEN insufficient permission

.github/workflows/blossom-ci.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright (c) 2022-2023, NVIDIA CORPORATION.
1+
# Copyright (c) 2022-2024, NVIDIA CORPORATION.
22
#
33
# Licensed under the Apache License, Version 2.0 (the "License");
44
# you may not use this file except in compliance with the License.
@@ -55,7 +55,7 @@ jobs:
5555
wbo4958,\
5656
wjxiz1992,\
5757
sperlingxx,\
58-
pxLi,\
58+
YanxuanLiu,\
5959
hyperbolic2346,\
6060
gerashegalov,\
6161
ttnghia,\
@@ -65,6 +65,7 @@ jobs:
6565
NVnavkumar,\
6666
yinqingh,\
6767
thirtiseven,\
68+
parthosa,\
6869
', format('{0},', github.actor)) && github.event.comment.body == 'build'
6970
steps:
7071
- name: Check if comment is issued by authorized person

.github/workflows/clang-format.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright (c) 2023, NVIDIA CORPORATION.
1+
# Copyright (c) 2023-2024, NVIDIA CORPORATION.
22
#
33
# Licensed under the Apache License, Version 2.0 (the "License");
44
# you may not use this file except in compliance with the License.
@@ -26,7 +26,7 @@ jobs:
2626
- uses: actions/checkout@v4
2727
with:
2828
submodules: true
29-
- uses: actions/setup-python@v4
29+
- uses: actions/setup-python@v5
3030
with:
3131
python-version: "3.10"
3232
- uses: pre-commit/[email protected]

.github/workflows/signoff-check.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright (c) 2022, NVIDIA CORPORATION.
1+
# Copyright (c) 2022-2024, NVIDIA CORPORATION.
22
#
33
# Licensed under the Apache License, Version 2.0 (the "License");
44
# you may not use this file except in compliance with the License.
@@ -23,7 +23,7 @@ jobs:
2323
signoff-check:
2424
runs-on: ubuntu-latest
2525
steps:
26-
- uses: actions/checkout@v3
26+
- uses: actions/checkout@v4
2727

2828
- name: sigoff-check job
2929
uses: ./.github/workflows/signoff-check

.gitmodules

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
[submodule "thirdparty/cudf"]
22
path = thirdparty/cudf
33
url = https://github.com/rapidsai/cudf.git
4-
branch = branch-24.02
4+
branch = branch-24.04

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ $ ./build/build-in-docker install ...
160160
```
161161

162162
Now cd to ~/repos/NVIDIA/spark-rapids and build with one of the options from
163-
[spark-rapids instructions](https://github.com/NVIDIA/spark-rapids/blob/branch-24.02/CONTRIBUTING.md#building-from-source).
163+
[spark-rapids instructions](https://github.com/NVIDIA/spark-rapids/blob/branch-24.04/CONTRIBUTING.md#building-from-source).
164164

165165
```bash
166166
$ ./build/buildall

build-libcudf.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0"?>
22
<!--
3-
Copyright (c) 2022, NVIDIA CORPORATION.
3+
Copyright (c) 2022-2024, NVIDIA CORPORATION.
44
55
Licensed under the Apache License, Version 2.0 (the "License");
66
you may not use this file except in compliance with the License.
@@ -40,13 +40,16 @@
4040
<arg value="-DBUILD_TESTS=OFF"/>
4141
<arg value="-DCMAKE_CUDA_ARCHITECTURES=${GPU_ARCHS}"/>
4242
<arg value="-DCMAKE_INSTALL_PREFIX=${libcudf.install.path}"/>
43+
<arg value="-DCUDF_DEPENDENCY_PIN_MODE=${libcudf.dependency.mode}"/>
4344
<arg value="-DCUDA_STATIC_RUNTIME=ON"/>
4445
<arg value="-DCUDF_ENABLE_ARROW_S3=OFF"/>
4546
<arg value="-DCUDF_ENABLE_ARROW_PARQUET=ON"/>
4647
<arg value="-DCUDF_USE_ARROW_STATIC=ON"/>
4748
<arg value="-DCUDF_USE_PER_THREAD_DEFAULT_STREAM=${CUDF_USE_PER_THREAD_DEFAULT_STREAM}" />
49+
<arg value="-DLIBCUDF_LOGGING_LEVEL=${RMM_LOGGING_LEVEL}" />
4850
<arg value="-DRMM_LOGGING_LEVEL=${RMM_LOGGING_LEVEL}" />
4951
<arg value="-DUSE_GDS=${USE_GDS}" />
52+
<arg value="-C=${cudf.pin.path}/setup.cmake"/>
5053
</exec>
5154

5255
<exec dir="${libcudf.build.path}"

build/build-info

Lines changed: 27 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#!/usr/bin/env bash
22

33
#
4-
# Copyright (c) 2022, NVIDIA CORPORATION. All rights reserved.
4+
# Copyright (c) 2022-2024, NVIDIA CORPORATION. All rights reserved.
55
#
66
# Licensed under the Apache License, Version 2.0 (the "License");
77
# you may not use this file except in compliance with the License.
@@ -20,18 +20,42 @@
2020
# Arguments:
2121
# version - The current version of the project
2222
# git_path - The path to the repository
23+
# libcudf_path - The path to the libcudf library
2324
set -e
25+
set -o pipefail
2426

2527
echo_build_properties() {
2628
version=$1
2729
git_path=$2
28-
shift 2
30+
libcudf_path=$3
31+
shift 3
2932
echo version=$version
30-
echo user=$USER
33+
echo user=$(whoami)
3134
echo revision=$(cd "$git_path" && git rev-parse HEAD)
3235
echo branch=$(cd "$git_path" && git rev-parse --abbrev-ref HEAD)
3336
echo date=$(date -u +%Y-%m-%dT%H:%M:%SZ)
3437
echo url=$(cd "$git_path" && git config --get remote.origin.url)
38+
gpu_architectures=$(
39+
cuobjdump "$libcudf_path" | gawk '
40+
match($0, /arch = sm_([0-9]+)/, tmp) {
41+
arch[tmp[1]] = 1
42+
}
43+
44+
END {
45+
n = asorti(arch)
46+
if (n == 0) {
47+
print "ERROR: No fatbin ELF / PTX code sections found" > "/dev/stderr"
48+
exit(1)
49+
}
50+
s = arch[1]
51+
for (i = 2; i <= n; i++) {
52+
s = s ";" arch[i]
53+
}
54+
print s
55+
}
56+
'
57+
)
58+
echo "gpu_architectures=$gpu_architectures"
3559
for arg in "$@"; do
3660
echo $arg
3761
done

ci/Jenkinsfile.premerge

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/usr/local/env groovy
22
/*
3-
* Copyright (c) 2022-2023, NVIDIA CORPORATION.
3+
* Copyright (c) 2022-2024, NVIDIA CORPORATION.
44
*
55
* Licensed under the Apache License, Version 2.0 (the "License");
66
* you may not use this file except in compliance with the License.
@@ -42,7 +42,7 @@ pipeline {
4242
agent {
4343
kubernetes {
4444
label "premerge-init-${BUILD_TAG}"
45-
cloud 'sc-ipp-blossom-prod'
45+
cloud "${common.CLOUD_NAME}"
4646
yaml cpuImage
4747
}
4848
}
@@ -93,7 +93,7 @@ pipeline {
9393

9494
def title = githubHelper.getIssue().title
9595
if (title ==~ /.*\[skip ci\].*/) {
96-
githubHelper.updateCommitStatus("$BUILD_URL", "Skipped", GitHubCommitState.SUCCESS)
96+
githubHelper.updateCommitStatus("", "Skipped", GitHubCommitState.SUCCESS)
9797
currentBuild.result == "SUCCESS"
9898
skipped = true
9999
return
@@ -113,7 +113,7 @@ pipeline {
113113
agent {
114114
kubernetes {
115115
label "premerge-docker-${BUILD_TAG}"
116-
cloud 'sc-ipp-blossom-prod'
116+
cloud "${common.CLOUD_NAME}"
117117
yaml pod.getDockerBuildYAML()
118118
workspaceVolume persistentVolumeClaimWorkspaceVolume(claimName: "${PVC}", readOnly: false)
119119
customWorkspace "${CUSTOM_WORKSPACE}"
@@ -122,7 +122,7 @@ pipeline {
122122

123123
steps {
124124
script {
125-
githubHelper.updateCommitStatus("$BUILD_URL", "Running", GitHubCommitState.PENDING)
125+
githubHelper.updateCommitStatus("", "Running", GitHubCommitState.PENDING)
126126
checkout(
127127
changelog: false,
128128
poll: true,
@@ -200,7 +200,7 @@ git --no-pager diff --name-only HEAD \$BASE -- ${PREMERGE_DOCKERFILE} || true"""
200200
agent {
201201
kubernetes {
202202
label "premerge-ci-1-${BUILD_TAG}"
203-
cloud 'sc-ipp-blossom-prod'
203+
cloud "${common.CLOUD_NAME}"
204204
yaml pod.getGPUYAML("${IMAGE_PREMERGE}", "${env.GPU_RESOURCE}", '8', '32Gi')
205205
workspaceVolume persistentVolumeClaimWorkspaceVolume(claimName: "${PVC}", readOnly: false)
206206
customWorkspace "${CUSTOM_WORKSPACE}"
@@ -229,14 +229,15 @@ git --no-pager diff --name-only HEAD \$BASE -- ${PREMERGE_DOCKERFILE} || true"""
229229
}
230230

231231
if (currentBuild.currentResult == "SUCCESS") {
232-
githubHelper.updateCommitStatus("$BUILD_URL", "Success", GitHubCommitState.SUCCESS)
232+
githubHelper.updateCommitStatus("", "Success", GitHubCommitState.SUCCESS)
233233
} else {
234234
// upload log only in case of build failure
235235
def guardWords = ["gitlab.*?\\.com", "urm.*?\\.com"]
236236
guardWords.add("nvidia-smi(?s)(.*?)(?=git)") // hide GPU info
237+
guardWords.add("sc-ipp*") // hide cloud info
237238
githubHelper.uploadLogs(this, env.JOB_NAME, env.BUILD_NUMBER, null, guardWords)
238239

239-
githubHelper.updateCommitStatus("$BUILD_URL", "Fail", GitHubCommitState.FAILURE)
240+
githubHelper.updateCommitStatus("", "Fail", GitHubCommitState.FAILURE)
240241
}
241242

242243
if (TEMP_IMAGE_BUILD) {

0 commit comments

Comments
 (0)