Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NCCL_ASYNC_ERROR_HANDLING deprecation warning #711

Merged
merged 3 commits into from
Mar 17, 2025
Merged

Fix NCCL_ASYNC_ERROR_HANDLING deprecation warning #711

merged 3 commits into from
Mar 17, 2025

Conversation

simonbyrne
Copy link
Contributor

@simonbyrne simonbyrne commented Nov 15, 2024 •
edited
Loading

It looks like the patch from pytorch/pytorch#114077 landed in torch 2.2.0.

Fixes #568.

Modulus Pull Request

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

@simonbyrne
Copy link
Contributor Author

@ram-cherukuri

@mnabian mnabian requested a review from akshaysubr November 26, 2024 02:11
akshaysubr
akshaysubr approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@akshaysubr akshaysubr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@simonbyrne
Copy link
Contributor Author

Can we please merge this? It's been sitting here for months.

@akshaysubr
Copy link
Collaborator

/blossom-ci

@akshaysubr akshaysubr merged commit fb70138 into NVIDIA:main Mar 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaysubr akshaysubr akshaysubr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛[BUG]: NCCL_ASYNC_ERROR_HANDLING deprecation warning
2 participants
@simonbyrne @akshaysubr