Decompose nv-ingest-ms-runtime into nv-ingest-rest-api & nv-ingest-worker #965
Conversation
| - ${DATASET_ROOT:-./data}:/workspace/data | ||
| cap_add: | ||
| - sys_nice | ||
| environment: |
There was a problem hiding this comment.
I don't like having 2 services that share basically the same environment variables simply because trying to keep things synced never ends well. Just leaving here for now and we can discuss approaches.
Notice nv-ingest-rest-api has nearly the same variables
It also seems cumbersome to try and say "well rest-api only needs these envs but then worker needs these other ones and some of the same" seems like blanket of all env variables and a single place to store them all would be preferred. Also easier for docs
There was a problem hiding this comment.
Do we need any of the args above for the rest service? I didn't think we were doing any real work there.
| capabilities: [gpu] | ||
|
|
||
|
|
||
| nv-ingest-worker: |
There was a problem hiding this comment.
Can we call this nv-ingest-service, so it aligns with all the unit tests.
| - ${DATASET_ROOT:-./data}:/workspace/data | ||
| cap_add: | ||
| - sys_nice | ||
| environment: |
There was a problem hiding this comment.
Do we need any of the args above for the rest service? I didn't think we were doing any real work there.
2 participants
Description
This PR splits the monolithic nv-ingest-ms-runtime service into 2 separate, and new, services.
The driver for this change is several things.
Checklist