Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[drive-by-feedback] Packaging quirks #85

Open
webknjaz opened this issue Dec 7, 2024 · 2 comments
Open

[drive-by-feedback] Packaging quirks #85

webknjaz opened this issue Dec 7, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@webknjaz
Copy link

webknjaz commented Dec 7, 2024

As I was looking into the repo, I noticed a few things that could be fixed:

  1. https://pypi.org/p/numba-cuda does not display the picture from the README as relative URLs aren't resolved to GitHub. The solution is to use an absolute URL. Another option would be switching away from setuptools to something like Hatchling that supports dynamically modifying the README when creating the dists (but this is probably not an option, seeing the hacks in setup.py).
  2. [build-system].requires in pyproject.toml contains wheel. It's a common misconception. It's not needed at all and should be dropped. Older versions of setuptools would auto-inject it as a dependency when building wheels, but the modern ones have wheel vendored within setuptools. It was never necessary but existed in the docs as an incorrect example for some time. I fixed those setuptools docs years ago.
@webknjaz webknjaz added the bug Something isn't working label Dec 7, 2024
@gmarkall
Copy link
Collaborator

gmarkall commented Dec 9, 2024

Thanks for these observations! I'll look at fixing these when I have a little time before packaging a new version.

but this is probably not an option, seeing the hacks in setup.py

Those hacks are not intended to live forever (just until a Numba release supports getting the target from this package, rather than numba-cuda needing to get "in front" of it). So it could be an option in future.

[build-system].requires in pyproject.toml contains wheel. It's a common misconception.

Thanks, I'm not sure where I got that from (I think I took inspiration from another pyproject.toml somewhere, but I don't recall where).

@webknjaz
Copy link
Author

I'm not sure where I got that from (I think I took inspiration from another pyproject.toml somewhere, but I don't recall where).

It used to be in the the setuptools' own docs (I think I might've added that example in the first place). But at some point I noticed the problem and fixed those docs while a lot of projects have already copied the problematic example by then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants