You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As I was looking into the repo, I noticed a few things that could be fixed:
https://pypi.org/p/numba-cuda does not display the picture from the README as relative URLs aren't resolved to GitHub. The solution is to use an absolute URL. Another option would be switching away from setuptools to something like Hatchling that supports dynamically modifying the README when creating the dists (but this is probably not an option, seeing the hacks in setup.py).
[build-system].requires in pyproject.toml contains wheel. It's a common misconception. It's not needed at all and should be dropped. Older versions of setuptools would auto-inject it as a dependency when building wheels, but the modern ones have wheel vendored within setuptools. It was never necessary but existed in the docs as an incorrect example for some time. I fixed those setuptools docs years ago.
The text was updated successfully, but these errors were encountered:
Thanks for these observations! I'll look at fixing these when I have a little time before packaging a new version.
but this is probably not an option, seeing the hacks in setup.py
Those hacks are not intended to live forever (just until a Numba release supports getting the target from this package, rather than numba-cuda needing to get "in front" of it). So it could be an option in future.
[build-system].requires in pyproject.toml contains wheel. It's a common misconception.
Thanks, I'm not sure where I got that from (I think I took inspiration from another pyproject.toml somewhere, but I don't recall where).
I'm not sure where I got that from (I think I took inspiration from another pyproject.toml somewhere, but I don't recall where).
It used to be in the the setuptools' own docs (I think I might've added that example in the first place). But at some point I noticed the problem and fixed those docs while a lot of projects have already copied the problematic example by then.
As I was looking into the repo, I noticed a few things that could be fixed:
setuptools
to something like Hatchling that supports dynamically modifying the README when creating the dists (but this is probably not an option, seeing the hacks insetup.py
).[build-system].requires
inpyproject.toml
containswheel
. It's a common misconception. It's not needed at all and should be dropped. Older versions ofsetuptools
would auto-inject it as a dependency when building wheels, but the modern ones havewheel
vendored withinsetuptools
. It was never necessary but existed in the docs as an incorrect example for some time. I fixed thosesetuptools
docs years ago.The text was updated successfully, but these errors were encountered: