Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__version__ string of conda-forge cuda-python 12.6.2 & 11.8.5 build 1 is dirty #308

Closed
leofang opened this issue Dec 17, 2024 · 2 comments
Closed
Assignees
Labels
bug Something isn't working cuda.bindings Everything related to the cuda.bindings module P0 High priority - Must do! packaging Anything related to wheels or Conda packages

Comments

@leofang
Copy link
Member

leofang commented Dec 17, 2024

+ python -c 'import cuda.bindings; print(cuda.bindings.__version__)'
0+untagged.310.ge14f0f1.dirty

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1107951&view=logs&j=5b44946f-b0b5-570f-e735-950feabb4722&t=61cfdd87-b98a-5bb9-08e2-446c3dd957d8&l=2050

This affects cuda.core logic, ex:

_py_major_ver = int(importlib.metadata.version("cuda-python").split(".")[0])

@leofang leofang added bug Something isn't working cuda.bindings Everything related to the cuda.bindings module P0 High priority - Must do! packaging Anything related to wheels or Conda packages labels Dec 17, 2024
@leofang leofang added this to the cuda-python 12-next, 11-next milestone Dec 17, 2024
@leofang leofang changed the title __version__ string of conda-forge cuda-python 12.6.2 build 1 is dirty __version__ string of conda-forge cuda-python 12.6.2 & 11.8.5 build 1 is dirty Dec 24, 2024
@leofang
Copy link
Member Author

leofang commented Dec 24, 2024

12.6.2 is fixed (conda-forge/cuda-python-feedstock#100). Need to fix 11.8.5 (conda-forge/cuda-python-feedstock#104).

@leofang leofang self-assigned this Dec 24, 2024
@leofang
Copy link
Member Author

leofang commented Dec 24, 2024

Both 12.6.2 & 11.8.5 build 2 are out. Root cause is that the git archived generated by GitHub did not have the git keywords properly populated (conda-forge/cuda-python-feedstock#100 (comment)), most likely due to some versioneer's quirky behaviors

@leofang leofang closed this as completed Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cuda.bindings Everything related to the cuda.bindings module P0 High priority - Must do! packaging Anything related to wheels or Conda packages
Projects
None yet
Development

No branches or pull requests

1 participant