Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable UB bulk wgrad when weights are frozen #702

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

minitu
Copy link
Contributor

@minitu minitu commented Mar 5, 2024

Fixes shape mismatch problem during backward with frozen weights (e.g., fine-tuning benchmarks) when TP overlap and UB bulk wgrad is enabled.

@minitu minitu force-pushed the jaeminc/ub_bulk_wgrad_fix branch from ffd8c59 to 7b7a281 Compare March 5, 2024 06:23
@minitu minitu force-pushed the jaeminc/ub_bulk_wgrad_fix branch from 7b7a281 to 4db53b4 Compare March 5, 2024 06:23
Copy link
Member

@ksivaman ksivaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksivaman
Copy link
Member

ksivaman commented Mar 5, 2024

/te-ci pytorch

@ksivaman ksivaman merged commit b0f6535 into NVIDIA:main Mar 5, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants