Support FP16 for user buffer #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hongbin Liu <[email protected]>
timmoon10
reviewed
Mar 4, 2024
|
/te-ci pytorch |
timmoon10
approved these changes
Mar 6, 2024
ksivaman
reviewed
Mar 6, 2024
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
|
/te-ci pytorch |
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
|
/te-ci pytorch |
@timmoon10 A China customer, Baidu, verified the fp16+user buffer by hard-coding the dtype to fp16. |
rachitgarg91
pushed a commit
to rachitgarg91/TransformerEngine
that referenced
this pull request
Mar 12, 2024
* add_dtype_for_userbuf Signed-off-by: Hongbin Liu <[email protected]> * Update transformer_engine/pytorch/module/base.py Signed-off-by: Tim Moon <[email protected]> * Fix syntax Signed-off-by: Kirthi Shankar Sivamani <[email protected]> * Fix lint Signed-off-by: Kirthi Shankar Sivamani <[email protected]> --------- Signed-off-by: Hongbin Liu <[email protected]> Signed-off-by: Tim Moon <[email protected]> Signed-off-by: Kirthi Shankar Sivamani <[email protected]> Co-authored-by: Hongbin Liu <[email protected]> Co-authored-by: Tim Moon <[email protected]> Co-authored-by: Kirthi Shankar Sivamani <[email protected]> Signed-off-by: rachitg <[email protected]>
Kite0011
pushed a commit
to Kite0011/TransformerEngine
that referenced
this pull request
Mar 19, 2024
* add_dtype_for_userbuf Signed-off-by: Hongbin Liu <[email protected]> * Update transformer_engine/pytorch/module/base.py Signed-off-by: Tim Moon <[email protected]> * Fix syntax Signed-off-by: Kirthi Shankar Sivamani <[email protected]> * Fix lint Signed-off-by: Kirthi Shankar Sivamani <[email protected]> --------- Signed-off-by: Hongbin Liu <[email protected]> Signed-off-by: Tim Moon <[email protected]> Signed-off-by: Kirthi Shankar Sivamani <[email protected]> Co-authored-by: Hongbin Liu <[email protected]> Co-authored-by: Tim Moon <[email protected]> Co-authored-by: Kirthi Shankar Sivamani <[email protected]> Signed-off-by: kitefang <[email protected]>
Kite0011
pushed a commit
to Kite0011/TransformerEngine
that referenced
this pull request
Mar 20, 2024
* add_dtype_for_userbuf Signed-off-by: Hongbin Liu <[email protected]> * Update transformer_engine/pytorch/module/base.py Signed-off-by: Tim Moon <[email protected]> * Fix syntax Signed-off-by: Kirthi Shankar Sivamani <[email protected]> * Fix lint Signed-off-by: Kirthi Shankar Sivamani <[email protected]> --------- Signed-off-by: Hongbin Liu <[email protected]> Signed-off-by: Tim Moon <[email protected]> Signed-off-by: Kirthi Shankar Sivamani <[email protected]> Co-authored-by: Hongbin Liu <[email protected]> Co-authored-by: Tim Moon <[email protected]> Co-authored-by: Kirthi Shankar Sivamani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.