[JAX] Support layernorm/rmsnorm sm_margin control through environment variable #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/te-ci jax |
|
/te-ci jax |
zlsh80826
force-pushed
the
rewang/support-ln-sm-margin
branch
2 times, most recently
from
be1c481 to
00dad5f
Compare
|
/te-ci jax |
Signed-off-by: Reese Wang <[email protected]>
zlsh80826
force-pushed
the
rewang/support-ln-sm-margin
branch
from
00dad5f to
286638a
Compare
|
/te-ci jax |
|
Hi @ksivaman @timmoon10 @denera, all tests are passed. Could you help review the PR? Thanks! |
denera
reviewed
Nov 29, 2023
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does support layernorm and rmsnorm sm_margin control through environment variables
NVTE_FWD_LAYERNORM_SM_MARGINandNVTE_BWD_LAYERNORM_SM_MARGIN