Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(code quality): Add comments for parallel welford variance calculation #423

Merged

Conversation

jon-chuang
Copy link
Contributor

@jon-chuang jon-chuang commented Sep 6, 2023

Make code more readable

Partially fixes: #422

@jon-chuang jon-chuang force-pushed the jon-chuang/document-parallel-welford branch 2 times, most recently from 0eda435 to 3237ac7 Compare September 6, 2023 14:14
Signed-off-by: Jon Chuang <[email protected]>
@jon-chuang jon-chuang force-pushed the jon-chuang/document-parallel-welford branch from 3237ac7 to 4f792c7 Compare September 6, 2023 14:29
@ptrendx
Copy link
Member

ptrendx commented Nov 16, 2023

Thanks for your contribution :-)!

@ptrendx ptrendx merged commit e6676c5 into NVIDIA:main Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(perf): Investigate performance of Welford layer norm
2 participants