Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAX] Move parallel encoder tests to L0 distributed test set. #1356

Merged
merged 7 commits into from
Dec 18, 2024

Conversation

phu0ngng
Copy link
Collaborator

@phu0ngng phu0ngng commented Dec 4, 2024

Description

test_multigpu_encoder.py, test_multiprocessing_encoder.py, and test_model_parallel_encoder.py belonged to the L0 test set thus were always executed on a single GPU node in the CI.

This PR moved those tests into the L0 distributed test set.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@phu0ngng phu0ngng requested a review from mingxu1067 December 4, 2024 19:41
@phu0ngng phu0ngng force-pushed the jax_multi_test branch 2 times, most recently from d8e69fd to 00419ba Compare December 12, 2024 15:39
@phu0ngng phu0ngng requested review from zlsh80826 and ksivaman and removed request for mingxu1067 December 18, 2024 13:55
Copy link
Member

@ksivaman ksivaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phu0ngng
Copy link
Collaborator Author

Pipeline #129367567.

@phu0ngng phu0ngng merged commit a3b32ec into NVIDIA:main Dec 18, 2024
14 checks passed
@phu0ngng phu0ngng deleted the jax_multi_test branch December 18, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants