Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attention mask type for Flash Attention + CP + THD #1354

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

xrennvidia
Copy link
Collaborator

@xrennvidia xrennvidia commented Dec 4, 2024

Description

Fix qkv_format setting in DotProductAttention.
Use padding mask type for flash attention with THD format in CP unit tests.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@xrennvidia
Copy link
Collaborator Author

/te-ci pytorch L1

@xrennvidia xrennvidia requested a review from cyanguwa December 4, 2024 04:36
@xrennvidia xrennvidia merged commit d978e80 into NVIDIA:main Dec 5, 2024
14 checks passed
@xrennvidia xrennvidia deleted the xren/cp_mask_type branch December 5, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants