Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAX] Scale sequence length in CP tests to avoid tiny sizes. #1347

Conversation

mgoldfarb-nvidia
Copy link
Collaborator

@mgoldfarb-nvidia mgoldfarb-nvidia commented Nov 26, 2024

Description

Avoids running with tiny sequence lengths when CP size is large in the Jax distributed fused attention tests.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

Update unit test to scale sequence length by CP size.

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@zlsh80826
Copy link
Collaborator

/te-ci jax L1

@mgoldfarb-nvidia
Copy link
Collaborator Author

/te-ci jax L1

@mgoldfarb-nvidia mgoldfarb-nvidia merged commit d3cbccd into NVIDIA:main Dec 4, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants