Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Add function to convert container to string #1342

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

timmoon10
Copy link
Collaborator

Description

This PR adds a C++ utility function that can convert some C++ containers (mainly vector) to a string. This can be used to generate more descriptive error messages:

NVTE_CHECK(in.shape == out.shape,
           "Input dims ", in.shape, " and output dims ", out.shape, " do not match");
// Assertion failed: in.shape == out.shape, Input dims (2,4) and output dims (8) do not match

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

  • Add C++ utility function to convert container to string

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Collaborator

@phu0ngng phu0ngng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite practical. Thanks.

@timmoon10
Copy link
Collaborator Author

/te-ci

@timmoon10 timmoon10 merged commit 8952bc4 into NVIDIA:main Nov 22, 2024
14 of 15 checks passed
@timmoon10 timmoon10 deleted the print-vectors branch November 22, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants