Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug nightly docs #1338

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Debug nightly docs #1338

merged 2 commits into from
Dec 5, 2024

Conversation

timmoon10
Copy link
Collaborator

Description

Our nightly docs at https://nvidia.github.io/TransformerEngine/ were last updated on 12/13/23. This PR is an attempt to get this working again.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

  • Fix version mismatch in artifact actions
  • Fix incorrect artifact name for deployed docs

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@timmoon10 timmoon10 added documentation Improvements or additions to documentation testing Improvements to tests or testing infrastructure labels Nov 15, 2024
@timmoon10
Copy link
Collaborator Author

This PR gets us past the previous error: https://github.com/NVIDIA/TransformerEngine/actions/runs/11862971447
I haven't been able to fully test it since the repo is configured to prevent deployments from PRs (probably a good idea).

@timmoon10 timmoon10 marked this pull request as ready for review November 15, 2024 20:37
with:
name: "te_docs"
path: "html"
- name: Prepare for pages
uses: actions/[email protected]
with:
name: github-pages
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at logs before we changed the artifact action versions, we were experiencing failures due to mismatched artifact names:
https://github.com/NVIDIA/TransformerEngine/actions/runs/10686862322/job/29623182933

@timmoon10 timmoon10 merged commit 71ada55 into NVIDIA:main Dec 5, 2024
14 checks passed
@timmoon10 timmoon10 deleted the debug-nightly-docs branch December 5, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation testing Improvements to tests or testing infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant