Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSDP with FP8 is not working #1247

Open
eljandoubi opened this issue Oct 14, 2024 · 1 comment
Open

FSDP with FP8 is not working #1247

eljandoubi opened this issue Oct 14, 2024 · 1 comment

Comments

@eljandoubi
Copy link

eljandoubi commented Oct 14, 2024

Image

layernorm needs to have reshape instead of view.
In pytorch base module, torch.get_autocast_gpu_dtype() is deprecated.
@timmoon10 @ksivaman @ptrendx @cyanguwa

@timmoon10
Copy link
Collaborator

TE does not handle non-contiguous data very well. I like the idea of coercing data to be contiguous, but that adds non-trivial CPU overhead even if it has no effect on GPU.

Related: #417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants