Skip to content

Commit 2c41083

Browse files
authored
Explicitly specify that PyTorch QA tests use PyTorch (#476)
Signed-off-by: Tim Moon <[email protected]>
1 parent 35e687d commit 2c41083

File tree

7 files changed

+6
-6
lines changed

7 files changed

+6
-6
lines changed

.github/workflows/lint.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
run: |
1919
export CPP_ONLY=1
2020
export TE_PATH=.
21-
bash ./qa/L0_lint/test.sh
21+
bash ./qa/L0_pytorch_lint/test.sh
2222
pytorch_pylint:
2323
name: 'PyTorch Python'
2424
runs-on: ubuntu-latest
@@ -34,7 +34,7 @@ jobs:
3434
pip install flash-attn==1.0.2
3535
export PYTHON_ONLY=1
3636
export TE_PATH=.
37-
bash ./qa/L0_lint/test.sh
37+
bash ./qa/L0_pytorch_lint/test.sh
3838
jax_cpplint:
3939
name: 'JAX C++'
4040
runs-on: ubuntu-latest

CONTRIBUTING.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Coding Guidelines
2020

2121
.. code-block:: bash
2222
23-
TE_PATH=<path to TE source> bash qa/L0_lint/test.sh
23+
TE_PATH=<path to TE source> bash qa/L0_<framework>_lint/test.sh
2424
2525
* Avoid introducing unnecessary complexity into existing code so that maintainability and
2626
readability are preserved.
@@ -41,7 +41,7 @@ Coding Guidelines
4141

4242
- In the :bash:`qa/` directory, there are basic sanity tests scripted in directories named
4343
`L0_...`. A given test can be executed by running the :bash:`./test.sh` command in each test
44-
directory. The :bash:`test.sh` script assume that the TE source can be found under
44+
directory. The :bash:`test.sh` script assumes that the TE source can be found under
4545
:bash:`/opt/transformerengine`. This assumption can be changed by setting :bash:`TE_PATH`
4646
environment variable to the directory containing TE source.
4747
- One of the tests, `L0_license` tests for valid NVIDIA copyright and license text. If you create
File renamed without changes.
File renamed without changes.
File renamed without changes.

qa/L0_lint/test.sh renamed to qa/L0_pytorch_lint/test.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ set -e
99
pip install cpplint==1.6.0 pylint==2.13.5
1010
if [ -z "${PYTHON_ONLY}" ]
1111
then
12-
cp $TE_PATH/qa/L0_lint/CPPLINT.cfg $TE_PATH
12+
cp $TE_PATH/qa/L0_pytorch_lint/CPPLINT.cfg $TE_PATH
1313
cd $TE_PATH
1414
echo "Checking common API headers"
1515
cpplint --root transformer_engine/common/include --recursive transformer_engine/common/include
@@ -19,7 +19,7 @@ then
1919
fi
2020
if [ -z "${CPP_ONLY}" ]
2121
then
22-
cp $TE_PATH/qa/L0_lint/pylintrc $TE_PATH
22+
cp $TE_PATH/qa/L0_pytorch_lint/pylintrc $TE_PATH
2323
cd $TE_PATH
2424
echo "Checking Python files"
2525
pylint --recursive=y transformer_engine/common transformer_engine/pytorch
File renamed without changes.

0 commit comments

Comments
 (0)