Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add test_uneven_common_crawl_range PyTest #236

Open
sarahyurick opened this issue Sep 9, 2024 · 0 comments · May be fixed by #454
Open

Re-add test_uneven_common_crawl_range PyTest #236

sarahyurick opened this issue Sep 9, 2024 · 0 comments · May be fixed by #454

Comments

@sarahyurick
Copy link
Collaborator

sarahyurick commented Sep 9, 2024 •
edited
Loading

PR #235 skips test_uneven_common_crawl_range because of how flaky it is. In the future, we may want to debug and re-add it.

def test_uneven_common_crawl_range(self):
    start_snapshot = "2021-03"
    end_snapshot = "2021-11"
    urls = get_common_crawl_urls(start_snapshot, end_snapshot)

    assert (
        urls[0]
        == "https://data.commoncrawl.org/crawl-data/CC-MAIN-2021-10/segments/1614178347293.1/warc/CC-MAIN-20210224165708-20210224195708-00000.warc.gz"
    )
    assert (
        urls[-1]
        == "https://data.commoncrawl.org/crawl-data/CC-MAIN-2021-04/segments/1610704847953.98/warc/CC-MAIN-20210128134124-20210128164124-00799.warc.gz"
    )
    assert len(urls) == 143840
@sarahyurick sarahyurick linked a pull request Dec 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Edit flaky PyTest in test_download sarahyurick/NeMo-Curator
1 participant
@sarahyurick