fix comments

Signed-off-by: Renaud Bourassa <[email protected]>

Author: dbnl-renaud

docs/source/workflows/observe/observe-workflow-with-dbnl.md

@@ -38,7 +38,7 @@ Create a new Trace Ingestion project in DBNL. To create a new project in DBNL:
 6. Click on Generate API Token and note down the generated **API Token**
 7. Note down the **Project Id** for the project
 
-### Step 3: Configure Your Environment
+## Step 3: Configure Your Environment
 
 Set the following environment variables in your terminal:
 
@@ -67,9 +67,6 @@ general:
     tracing:
       otelcollector:
         _type: dbnl
-        api_url: ${DBNL_API_URL}
-        api_token: ${DBNL_API_TOKEN}
-        project_id: ${DBNL_PROJECT_ID}
 ```
 
 ## Step 6: Run the workflow

examples/observability/simple_calculator_observability/configs/config-dbnl.yml

@@ -27,21 +27,14 @@ general:
     tracing:
       dbnl:
         _type: dbnl
-        api_url: ${DBNL_API_URL}
-        api_token: ${DBNL_API_TOKEN}
-        project_id: ${DBNL_PROJECT_ID}
+
+function_groups:
+  calculator:
+    _type: calculator
 
 functions:
-  calculator_multiply:
-    _type: calculator_multiply
-  calculator_inequality:
-    _type: calculator_inequality
-  calculator_divide:
-    _type: nat_simple_calculator/calculator_divide
   current_datetime:
     _type: current_datetime
-  calculator_subtract:
-    _type: calculator_subtract
 
 llms:
   nim_llm:
@@ -52,12 +45,7 @@ llms:
 
 workflow:
   _type: react_agent
-  tool_names:
-    - calculator_multiply
-    - calculator_inequality
-    - current_datetime
-    - calculator_divide
-    - calculator_subtract
+  tool_names: [calculator, current_datetime]
   llm_name: nim_llm
   verbose: true
   parse_agent_response_max_retries: 3

packages/nvidia_nat_opentelemetry/src/nat/plugins/opentelemetry/register.py

@@ -198,9 +198,9 @@ async def galileo_telemetry_exporter(config: GalileoTelemetryExporter, builder:
 class DBNLTelemetryExporter(BatchConfigMixin, TelemetryExporterBaseConfig, name="dbnl"):
     """A telemetry exporter to transmit traces to DBNL."""
 
-    api_url: str = Field(description="The DBNL API url.", default="http://localhost:8080/api")
-    api_token: str = Field(description="The DBNL API token.")
-    project_id: str = Field(description="The DBNL project id.")
+    api_url: str | None = Field(description="The DBNL API url.", default=None)
+    api_token: str | None = Field(description="The DBNL API token.", default=None)
+    project_id: str | None = Field(description="The DBNL project id.", default=None)
 
 
 @register_telemetry_exporter(config_type=DBNLTelemetryExporter)
@@ -209,12 +209,22 @@ async def dbnl_telemetry_exporter(config: DBNLTelemetryExporter, builder: Builde
 
     from nat.plugins.opentelemetry import OTLPSpanAdapterExporter
 
+    api_token = config.api_token or os.environ.get("DBNL_API_TOKEN")
+    if not api_token:
+        raise ValueError("API token is required for DBNL")
+    project_id = config.project_id or os.environ.get("DBNL_PROJECT_ID")
+    if not project_id:
+        raise ValueError("Project id is required for DBNL")
+
     headers = {
-        "Authorization": f"Bearer {config.api_token}",
-        "x-dbnl-project-id": config.project_id,
+        "Authorization": f"Bearer {api_token}",
+        "x-dbnl-project-id": project_id,
     }
 
-    endpoint = config.api_url.rstrip("/") + "/otel/v1/traces"
+    api_url = config.api_url or os.environ.get("DBNL_API_URL")
+    if not api_url:
+        raise ValueError("API url is required for DBNL")
+    endpoint = api_url.rstrip("/") + "/otel/v1/traces"
 
     yield OTLPSpanAdapterExporter(
         endpoint=endpoint,