fix comments

Signed-off-by: Renaud Bourassa <[email protected]>

Author: dbnl-renaud

docs/source/extend/telemetry-exporters.md

@@ -78,7 +78,7 @@ Examples of existing telemetry exporters include:
 - **Patronus**: Exports traces to Patronus via OTLP
 - **Galileo**: Exports traces to Galileo via OTLP
 - **RagaAI Catalyst**: Exports traces to RagaAI Catalyst
-- **DBNL**: Exports traces to DBNL via OLTP
+- **DBNL**: Exports traces to DBNL via OTLP
 
 ## Quick Start: Your First Telemetry Exporter
 
@@ -270,6 +270,7 @@ Before creating a custom exporter, check if your observability service is alread
 
 | Service | Type | Installation | Configuration |
 |---------|------|-------------|---------------|
+| **DBNL** | `dbnl` | `pip install "nvidia-nat[opentelemetry]"` | API url + API token + project id |
 | **File** | `file` | `pip install nvidia-nat` | local file or directory |
 | **Langfuse** | `langfuse` | `pip install "nvidia-nat[opentelemetry]"` | endpoint + API keys |
 | **LangSmith** | `langsmith` | `pip install "nvidia-nat[opentelemetry]"` | endpoint + API key |
@@ -279,7 +280,6 @@ Before creating a custom exporter, check if your observability service is alread
 | **Phoenix** | `phoenix` | `pip install "nvidia-nat[phoenix]"` | endpoint |
 | **RagaAI/Catalyst** | `catalyst` | `pip install "nvidia-nat[ragaai]"` | API key + project |
 | **Weave** | `weave` | `pip install "nvidia-nat[weave]"` | project name |
-| **DBNL** | `dbnl` | `pip install "nvidia-nat[opentelemetry]"` | endpoint + API key + project id |
 
 ### Simple Configuration Example
 

docs/source/workflows/observe/index.md

@@ -133,6 +133,7 @@ Each exporter has its own detailed configuration guide with complete setup instr
 - **[Catalyst](https://catalyst.raga.ai/)** - See [Observing with Catalyst](./observe-workflow-with-catalyst.md)
 - **Custom Exporters** - See [Adding Telemetry Exporters](../../extend/telemetry-exporters.md) for creating custom integrations
 - **[NVIDIA Data Flywheel Blueprint](https://build.nvidia.com/nvidia/build-an-enterprise-data-flywheel)** - See [Observing with Data Flywheel](./observe-workflow-with-data-flywheel.md)
+- **[DBNL](https://distributional.com/)** - See [Observing with DBNL](./observe-workflow-with-dbnl.md)
 - **[Dynatrace](https://dynatrace.com/)** - See [Observing with Dynatrace](./observe-workflow-with-dynatrace.md)
 - **File Export** - Built-in file-based tracing for local development and debugging
 - **[Galileo](https://galileo.ai/)** - See [Observing with Galileo](./observe-workflow-with-galileo.md)
@@ -142,7 +143,6 @@ Each exporter has its own detailed configuration guide with complete setup instr
 - **[Patronus](https://www.patronus.ai/)** - AI evaluation and monitoring platform
 - **[Phoenix](https://phoenix.arize.com/)** - See [Observing with Phoenix](./observe-workflow-with-phoenix.md)
 - **[W&B Weave](https://wandb.ai/site/weave/)** - See [Observing with W&B Weave](./observe-workflow-with-weave.md)
-- **[DBNL](https://distributional.com/)** - See [Observing with DBNL](./observe-workflow-with-dbnl.md)
 
 For complete configuration examples and setup instructions, refer to the individual guides linked above or check the `examples/observability/` directory.
 
@@ -152,6 +152,7 @@ For complete configuration examples and setup instructions, refer to the individ
 |----------|-----------|
 | Catalyst | Logging, Tracing |
 | Data Flywheel | Logging, Tracing |
+| DBNL | Logging, Tracing |
 | Dynatrace | Logging, Tracing |
 | Galileo | Logging, Tracing |
 | Langfuse | Logging, Tracing |
@@ -160,7 +161,6 @@ For complete configuration examples and setup instructions, refer to the individ
 | Patronus | Logging, Tracing |
 | Phoenix | Logging, Tracing |
 | W&B Weave | Logging, Tracing, W&B Weave Redaction, Evaluation Metrics |
-| DBNL | Logging, Tracing |
 
 ### NeMo Agent Toolkit Observability Components
 
@@ -204,10 +204,10 @@ For complete information about developing and integrating custom telemetry expor
 
 Observing with Catalyst <./observe-workflow-with-catalyst.md>
 Observing with Data Flywheel <./observe-workflow-with-data-flywheel.md>
+Observing with DBNL <./observe-workflow-with-dbnl.md>
 Observing with Dynatrace <./observe-workflow-with-dynatrace.md>
 Observing with Galileo <./observe-workflow-with-galileo.md>
 Observing with OTEL Collector <./observe-workflow-with-otel-collector.md>
 Observing with Phoenix <./observe-workflow-with-phoenix.md>
 Observing with W&B Weave <./observe-workflow-with-weave.md>
-Observing with DBNL <./observe-workflow-with-dbnl.md>
 ```

docs/source/workflows/observe/observe-workflow-with-dbnl.md

@@ -24,15 +24,15 @@ This guide provides a step-by-step process to enable observability in a NeMo Age
 
 ## Step 1: Install DBNL
 
-Visit [https://docs.dbnl.com/](https://docs.dbnl.com/) to install DBNL.
+Visit [https://docs.dbnl.com/get-started/quickstart](https://docs.dbnl.com/get-started/quickstart) to install DBNL.
 
 ## Step 2: Create a Project
 
 Create a new Trace Ingestion project in DBNL. To create a new project in DBNL:
 
-1. Navigate to your DBNL deployment (e.g. http://localhost:8080/)
+1. Navigate to your DBNL deployment (e.g. <http://localhost:8080/>)
 2. Go to Projects > + New Project
-3. Add a name for your project
+3. Name your project `nat-calculator`
 4. Add a LLM connection to your project
 5. Select Trace Ingestion as the project Data Source
 6. Click on Generate API Token and note down the generated **API Token**
@@ -67,8 +67,7 @@ general:
     tracing:
       otelcollector:
         _type: dbnl
-        # The endpoint where you have deployed DBNL
-        endpoint: ${DBNL_API_URL}/otel/v1/traces
+        api_url: ${DBNL_API_URL}
         api_token: ${DBNL_API_TOKEN}
         project_id: ${DBNL_PROJECT_ID}
 ```
@@ -95,6 +94,6 @@ As the workflow runs, telemetry data will start showing up in DBNL.
 Analyze the traces in DBNL. To analyze traces in DBNL:
 
 1. Navigate to your DBNL deployment (e.g. http://localhost:8080/)
-2. Go to Projects > <your_project_name>
+2. Go to Projects > nat-calculator
 
 For additional help, see the [DBNL docs](https://docs.dbnl.com/).

examples/observability/simple_calculator_observability/README.md

@@ -253,11 +253,11 @@ Transmit traces to Galileo for workflow observability.
 
 ### Analyze Traces with DBNL
 
-[DBNL](https://www.distributional.com/) helps you undestand your agent by analyzing your traces.
+[DBNL](https://www.distributional.com/) helps you understand your agent by analyzing your traces.
 
 1. Install DBNL:
 
-    Visit [https://docs.dbnl.com/](https://docs.dbnl.com/) to install DBNL.
+    Visit [https://docs.dbnl.com/get-started/quickstart](https://docs.dbnl.com/get-started/quickstart) to install DBNL.
 
 2. Create a trace ingestion project:
 

examples/observability/simple_calculator_observability/configs/config-dbnl.yml

@@ -27,9 +27,9 @@ general:
     tracing:
       dbnl:
         _type: dbnl
-        # endpoint: ${DBNL_API_URL}/otel/v1/traces
-        # api_token: ${DBNL_API_TOKEN}
-        # project_id: ${DBNL_PROJECT_ID}
+        api_url: ${DBNL_API_URL}
+        api_token: ${DBNL_API_TOKEN}
+        project_id: ${DBNL_PROJECT_ID}
 
 functions:
   calculator_multiply:

packages/nvidia_nat_opentelemetry/src/nat/plugins/opentelemetry/register.py

@@ -198,9 +198,9 @@ async def galileo_telemetry_exporter(config: GalileoTelemetryExporter, builder:
 class DBNLTelemetryExporter(BatchConfigMixin, TelemetryExporterBaseConfig, name="dbnl"):
     """A telemetry exporter to transmit traces to DBNL."""
 
-    endpoint: str = Field(description="The DBNL OTEL traces endpoint.", default="")
-    api_token: str = Field(description="The DBNL API token.", default="")
-    project_id: str = Field(description="The DBNL project id.", default="")
+    api_url: str = Field(description="The DBNL API url.", default="http://localhost:8080/api")
+    api_token: str = Field(description="The DBNL API token.")
+    project_id: str = Field(description="The DBNL project id.")
 
 
 @register_telemetry_exporter(config_type=DBNLTelemetryExporter)
@@ -209,18 +209,14 @@ async def dbnl_telemetry_exporter(config: DBNLTelemetryExporter, builder: Builde
 
     from nat.plugins.opentelemetry import OTLPSpanAdapterExporter
 
-    api_token = config.api_token or os.environ.get("DBNL_API_TOKEN")
-    project_id = config.project_id or os.environ.get("DBNL_PROJECT_ID")
+    api_token = config.api_token
+    project_id = config.project_id
     headers = {
         "Authorization": f"Bearer {api_token}",
         "x-dbnl-project-id": project_id,
     }
 
-    endpoint = config.endpoint
-    if not endpoint:
-        api_url = os.environ.get("DBNL_API_URL") or "http://localhost:8080/api"
-        endpoint = api_url.rstrip("/") + "/otel/v1/traces"
-    print(endpoint)
+    endpoint = config.api_url.rstrip("/") + "/otel/v1/traces"
 
     yield OTLPSpanAdapterExporter(
         endpoint=endpoint,