Skip to content

Commit 3f3b436

Browse files
committed
Merge branch 'main' into 'public-pr-rope-fix'
# Conflicts: # megatron/model/language_model.py
2 parents ea0f289 + 3a8ff0f commit 3f3b436

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

megatron/model/language_model.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -366,15 +366,12 @@ def __init__(self,
366366
rotary_dim = args.hidden_size // args.num_attention_heads \
367367
if args.kv_channels is None else args.kv_channels
368368

369-
if args.rotary_percent < 1.0:
370-
rotary_dim = int(rotary_dim * args.rotary_percent)
371-
372369
# partial rotary embeddings, which is better than full rotary
373370
# Wang and Komatsuzaki et al
374371
# https://github.com/kingoflolz/mesh-transformer-jax/
375372
self.rotary_pos_emb = RotaryEmbedding(
376373
rotary_dim,
377-
rotary_percent=args.rotary_percent,
374+
args.rotary_percent,
378375
seq_len_interpolation_factor=args.rotary_seq_len_interpolation_factor
379376
)
380377

0 commit comments

Comments
 (0)