-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Add cross product operator #469
Comments
I use cross products quite a bit and would be interested in implementing this. Anything I should be aware of regarding intended implementation or anything? |
Great! I think I would do the following:
|
Great thanks! I'll start on this sometime this week. |
As a matter of convention in MatX, are assertions best defined in the constructor for a class template specialization (e.g. like in |
In general if they're template parameters of the class they should go at the top of the class (doesn't even have to be in the ctor). In the corr.h case those are template parameters to the function so they must be in the function itself. |
This hasn't dropped off my radar, just haven't had a chance to look at it since implementing the runtime checks. |
Should support 3D points with an arbitrary rank (Nx3)
The text was updated successfully, but these errors were encountered: