Bug/fix dl pack tests on jetson (Issue #1233) - #1236
Merged
cliffburdick merged 2 commits intoAug 25, 2026
Conversation
- query actual memory space with GetPointerKind; do not hardcode kDLCUDA because the default memory space is platform dependend - add explicit tests for MATX_DEVICE_MEMORY and MATX_HOST_MEMORY
- wrap check_dl_export lambda calls in ASSERT_NO_FATAL_FAILURE; ASSERT_EQ only returns from the lambda, not the enclosing test - guard the default memory block by asserting that the default allocation can only ever be managed or pinned host memory - add coverage for MATX_HOST_MALLOC_MEMORY
Contributor
Greptile SummaryThe PR expands the legacy DLPack export test to validate device metadata for default, device, pinned-host, and pageable-host allocations while accommodating Jetson’s managed-memory fallback.
Confidence Score: 5/5The PR appears safe to merge because the added expectations match the current allocator invariants and DLPack device mappings. The changed test correctly handles Jetson’s pinned-host fallback and validates each explicit memory space against the corresponding production mapping without introducing a supported-platform failure. Important Files Changed
Reviews (1): Last reviewed commit: "Fix assertion leak and extend coverage w..." | Re-trigger Greptile |
Collaborator
|
/build |
cliffburdick
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the DLPackTestsAll.ExportLegacyDLPack (Issue #1233) suite on the Jetson platform and extends coverage with explicit device type test cases.
Changes
Out of scope
ToDlPackImpl's GetPointerKind lookup only resolves base pointers (see issue #1235)
Testing
Built and ran test_00_tensor_DLPackTests on Jetson Orin AGX: 58/58 tests pass.