From a2358c93783a6b4613986c7f2ba431e73512c7fd Mon Sep 17 00:00:00 2001 From: jjsjann123 Date: Fri, 3 Jan 2025 13:28:18 -0800 Subject: [PATCH 1/3] small fixes --- benchmarks/cpp/utils.cpp | 8 ++++---- csrc/scheduler/no_op.cpp | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/benchmarks/cpp/utils.cpp b/benchmarks/cpp/utils.cpp index f0c99f830f8..4d069b3ec47 100644 --- a/benchmarks/cpp/utils.cpp +++ b/benchmarks/cpp/utils.cpp @@ -190,14 +190,14 @@ int64_t runBenchmarkIterations( ->groups() .size() > 1; - const auto& compile_log = executor_cache->getMostRecentExecutorInfo(); - auto params = toString(compile_log.params); - auto lparams = toString( - compile_log.fusion_executor->as()->lastLaunchParams()); // Only set if not segmented. In the case of segmented fusions, // this could be confusing as the log would refect only the last // segment. Revisit if necessary. if (!segmented) { + const auto& compile_log = executor_cache->getMostRecentExecutorInfo(); + auto params = toString(compile_log.params); + auto lparams = toString( + compile_log.fusion_executor->as()->lastLaunchParams()); benchmark_state.SetLabel(params + lparams); } diff --git a/csrc/scheduler/no_op.cpp b/csrc/scheduler/no_op.cpp index a7eb6e2de1f..c9bbac94c97 100644 --- a/csrc/scheduler/no_op.cpp +++ b/csrc/scheduler/no_op.cpp @@ -111,7 +111,7 @@ std::unique_ptr NoOpScheduler::computeHeuristics( Fusion* fusion, SchedulerRuntimeInfo& runtime_info, HeuristicDataCache* data_cache) { - auto params = std::make_unique(SchedulerType::NoOp); + auto params = std::make_unique(SchedulerType::NoOp); params->cparams.index_type = runtime_info.getIndexType(); return params; } From ba5e6ff92545d3c2c1b92e18bfa833b609cfe5a7 Mon Sep 17 00:00:00 2001 From: jjsjann123 Date: Mon, 13 Jan 2025 08:13:23 -0800 Subject: [PATCH 2/3] removing NoOpHeuristic --- csrc/scheduler/no_op.cpp | 2 +- csrc/scheduler/no_op.h | 20 -------------------- 2 files changed, 1 insertion(+), 21 deletions(-) diff --git a/csrc/scheduler/no_op.cpp b/csrc/scheduler/no_op.cpp index c9bbac94c97..83ac97c1b0f 100644 --- a/csrc/scheduler/no_op.cpp +++ b/csrc/scheduler/no_op.cpp @@ -111,7 +111,7 @@ std::unique_ptr NoOpScheduler::computeHeuristics( Fusion* fusion, SchedulerRuntimeInfo& runtime_info, HeuristicDataCache* data_cache) { - auto params = std::make_unique(SchedulerType::NoOp); + auto params = std::make_unique(SchedulerType::NoOp); params->cparams.index_type = runtime_info.getIndexType(); return params; } diff --git a/csrc/scheduler/no_op.h b/csrc/scheduler/no_op.h index 3dbd53e8e0a..6f88f521bd5 100644 --- a/csrc/scheduler/no_op.h +++ b/csrc/scheduler/no_op.h @@ -45,24 +45,4 @@ class NoOpScheduler : public SchedulerEntry { } }; -//! Provides a dummy heuristic type to ensure -//! unified interface on NoOp scheduler. -class NoOpHeuristic : public HeuristicParams { - public: - using HeuristicParams::HeuristicParams; - NoOpHeuristic() : HeuristicParams(SchedulerType::NoOp) {}; - - size_t hash() const override { - return 0; - } - std::unique_ptr clone() const override { - return std::make_unique(*this); - } - - bool sameAs(const HeuristicParams* other) const override { - auto other_casted = dynamic_cast(other); - return other_casted != nullptr && other_casted->cparams == cparams; - }; -}; - } // namespace nvfuser From f94280c24b0967e401d13d6d0fb80ff1376d67b8 Mon Sep 17 00:00:00 2001 From: jjsjann123 Date: Mon, 13 Jan 2025 08:14:22 -0800 Subject: [PATCH 3/3] typo --- csrc/scheduler/no_op.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/csrc/scheduler/no_op.cpp b/csrc/scheduler/no_op.cpp index 83ac97c1b0f..a7eb6e2de1f 100644 --- a/csrc/scheduler/no_op.cpp +++ b/csrc/scheduler/no_op.cpp @@ -111,7 +111,7 @@ std::unique_ptr NoOpScheduler::computeHeuristics( Fusion* fusion, SchedulerRuntimeInfo& runtime_info, HeuristicDataCache* data_cache) { - auto params = std::make_unique(SchedulerType::NoOp); + auto params = std::make_unique(SchedulerType::NoOp); params->cparams.index_type = runtime_info.getIndexType(); return params; }