Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HiFiGAN] Missing class variable in model ResBlock2 #1297

Open
itakatz opened this issue May 18, 2023 · 0 comments
Open

[HiFiGAN] Missing class variable in model ResBlock2 #1297

itakatz opened this issue May 18, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@itakatz
Copy link

itakatz commented May 18, 2023

Related to PyTorch/SpeechSynthesis/HiFiGAN

Describe the bug
The class variable lrelu_slope is used in the class method forward but it is not defined. which raises an exception if HiFiGAN is trained with a parameter --resblock 2. The variable is referenced here:

xt = F.leaky_relu(x, self.lrelu_slope)

To Reproduce
Train HiFiGAN using the regular script (scripts/train.sh), adding the input parameter --resblock 2

Expected behavior
Training should run with no errors

Solution
Define the class variable in the __init__ method, similarly as in class ResBlock1, that is add:
self.lrelu_slope = LRELU_SLOPE

Environment

  • Container version: nvcr.io/nvidia/pytorch:22.12-py3
  • GPUs in the system: 8X A40
  • CUDA driver version: 520.61.05
@itakatz itakatz added the bug Something isn't working label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant