Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to load a font CSS file if none is specified. #35

Open
JoeGermuska opened this issue Mar 19, 2015 · 0 comments
Open

Don't try to load a font CSS file if none is specified. #35

JoeGermuska opened this issue Mar 19, 2015 · 0 comments

Comments

@JoeGermuska
Copy link
Member

If someone omits the "font" attribute from the Wordpress shortcode, the plugin specifies

  font: ""

in the configuration JSON, leading to a 404 trying to load something like http://knightlab.northwestern.edu/wp-content/plugins/knight-lab-timelinejs/css/themes/font/.css?2.24

we should try to omit the empty string configuration parameter when there is no font. (And similar for any other optional configuration properties)

(see this Wordpress Plugin Support ticket)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant