Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace EMS with AvailabilityManagerOptimumStart #1631

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

replace EMS with AvailabilityManagerOptimumStart #1631

wants to merge 6 commits into from
+9 −96

Conversation

eringold
Copy link
Collaborator

@eringold eringold commented Oct 26, 2023 •
edited
Loading

Pull request overview

Replace the EMS implementation of optimum start AHU control with AvailabilityManager:OptimumStart

Pull Request Author

  • Method changes or additions
  • All new and existing tests passes

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

@eringold eringold requested a review from mdahlhausen October 26, 2023 16:19
@eringold
Copy link
Collaborator Author

eringold commented Nov 3, 2023

The majority of test failures are from object differences ("A OS:EnergyManagementSystem:ProgramCallingManager was found only in the before model", "A OS:AvailabilityManager:OptimumStart was found only in the after model") which are expected given this change.

The performance test energy diff failures for SecondarySchool-90.1-2016-ASHRAE 169-2013-4A were investigated. The following differences were found in an annual run:

Energy % Diff Demand % Diff
Heating 5.7 -1.8
Cooling 0.08 -0.18
Fans 3.96 -0.28
Pumps 3.63 1.61
Total Elec 0.71 -0.12
Total Gas 1.4 -1.17

The overall HVAC system runtime increased by 2.4% with the modification, along with a slight drop in unmet cooling hours (250 -> 247). GIven the uncertainty in the modeled Availability Manager inputs for optimum start (as well as the original EMS implementation) I think these diffs are reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdahlhausen mdahlhausen Awaiting requested review from mdahlhausen

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove/replace EMS implementation of optimum start Air Loop control
2 participants
@eringold @mdahlhausen