Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

90.1 PRM: explicitly set dayofWeekforStartDay #1522

Open
eringold opened this issue Jun 2, 2023 · 0 comments
Open

90.1 PRM: explicitly set dayofWeekforStartDay #1522

eringold opened this issue Jun 2, 2023 · 0 comments
Labels
AppendixG Methods to enable the Appendix G model workflow

Comments

@eringold
Copy link
Collaborator

eringold commented Jun 2, 2023

@dmaddoxwhite @lymereJ @weilixu
I'm trying to use model_create_prm_stable_baseline_building in openstudio-standards v0.4.0 (packaged with OS 3.6.0) to generate the baseline for a propsed Outpatient building, and encountering a number of issues with either the model setup, or cases where the standards methods don't handle missing information gracefully. I'll try to document them as issues as I find them.

Models that use TMY files typically don't have 'dayofWeekforStartDay' set in YearDescription, and calling `model.getYearDescription.dayofWeekForStartDay' will return 'UseWeatherFile'. This causes an error here:

because day_of_week and start_day_num are nil (not found in start_day_map).

Suggest ensuring that models with TMY files attached have a valid start day, either by inserting model.getYearDescription.setDayofWeekforStartDay("Sunday") somewhere, or having a default set within get_weekday_values_from_8760.

@eringold eringold changed the title Appendix G: explicitly set dayofWeekforStartDay 90.1 PRM: explicitly set dayofWeekforStartDay Jun 2, 2023
@lymereJ lymereJ added the AppendixG Methods to enable the Appendix G model workflow label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AppendixG Methods to enable the Appendix G model workflow
Projects
None yet
Development

No branches or pull requests

2 participants