Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for failed.job in run_osw #98

Open
corymosiman12 opened this issue Jan 15, 2021 · 0 comments
Open

Check for failed.job in run_osw #98

corymosiman12 opened this issue Jan 15, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@corymosiman12
Copy link
Contributor

openstudio-extension-gem/lib/openstudio/extension/runner.rb

Lines 666 to 667 in dd30564

# DLM: this does not always return false for failed CLI runs, consider checking for failed.job file as backup test

We have scenarios in BuildingSync-gem that don't run successfully and don't get caught. To be robust, probably should check:

  • failed.job doesn't exist
  • finished.job does exist
@corymosiman12 corymosiman12 added the bug Something isn't working label Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@corymosiman12