Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default space type in get_space_types_from_building_type #164

Open
mioruggieroguida opened this issue Jun 16, 2023 · 0 comments
Open

Default space type in get_space_types_from_building_type #164

mioruggieroguida opened this issue Jun 16, 2023 · 0 comments

Comments

@mioruggieroguida
Copy link

I am using the get_space_types_from_building_type from OsLib_ModelGeneration to determine typical space ratios.

I have noticed that in the SecondarySchool and PrimarySchool building types (I haven't checked them all), multiple space types are set as default. For example here

if building_type == 'SecondarySchool'
  if ['DOE Ref Pre-1980', 'DOE Ref 1980-2004', 'ComStock DOE Ref Pre-1980', 'ComStock DOE Ref 1980-2004'].include?(template)
    hash['Auditorium'] = { ratio: 0.0504, space_type_gen: true, default: false, story_height: 26.0 }
    hash['Cafeteria'] = { ratio: 0.0319, space_type_gen: true, default: false }
    hash['Classroom'] = { ratio: 0.3528, space_type_gen: true, default: true }
    hash['Corridor'] = { ratio: 0.2144, space_type_gen: true, default: false, circ: true }
    hash['Gym'] = { ratio: 0.1009, space_type_gen: true, default: false, story_height: 26.0 }
    hash['Gym - audience'] = { ratio: 0.0637, space_type_gen: true, default: false, story_height: 26.0 }
    hash['Kitchen'] = { ratio: 0.0110, space_type_gen: true, default: false }
    hash['Library'] = { ratio: 0.0429, space_type_gen: true, default: false }
    hash['Lobby'] = { ratio: 0.0214, space_type_gen: true, default: false }
    hash['Mechanical'] = { ratio: 0.0349, space_type_gen: true, default: false }
    hash['Office'] = { ratio: 0.0543, space_type_gen: true, default: false }
    hash['Restroom'] = { ratio: 0.0214, space_type_gen: true, default: false }
  else
    hash['Auditorium'] = { ratio: 0.0504, space_type_gen: true, default: false, story_height: 26.0 }
    hash['Cafeteria'] = { ratio: 0.0319, space_type_gen: true, default: false }
    hash['Classroom'] = { ratio: 0.3041, space_type_gen: true, default: true } 
    hash['ComputerRoom'] = { ratio: 0.0487, space_type_gen: true, default: true }
    hash['Corridor'] = { ratio: 0.2144, space_type_gen: true, default: false, circ: true }
    hash['Gym'] = { ratio: 0.1646, space_type_gen: true, default: false, story_height: 26.0 }
    hash['Kitchen'] = { ratio: 0.0110, space_type_gen: true, default: false }
    hash['Library'] = { ratio: 0.0429, space_type_gen: true, default: false }
    hash['Lobby'] = { ratio: 0.0214, space_type_gen: true, default: false }
    hash['Mechanical'] = { ratio: 0.0349, space_type_gen: true, default: false }
    hash['Office'] = { ratio: 0.0543, space_type_gen: true, default: false }
    hash['Restroom'] = { ratio: 0.0214, space_type_gen: true, default: false }

both ClassRoom and ComputerRoom have default set to true. The same happens for PrimarySchool.

Is this a bug or have I misunderstood the meaning of the default key?

I have tested and the second space type set to true is the one that is assigned to every space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant