Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init_gem: upddate gemspec template to match the root gemspec (ruby 2.7.0 not 2.5.0, etc) #127

Open
jmarrec opened this issue Jun 3, 2021 · 3 comments
Assignees

Comments

@jmarrec
Copy link
Contributor

jmarrec commented Jun 3, 2021

init_gem: upddate gemspec template to match the root gemspec (ruby 2.7.0 not 2.5.0, etc)

spec.required_ruby_version = '~> 2.5.0'
spec.add_development_dependency 'bundler', '~> 2.1'
spec.add_development_dependency 'rake', '~> 13.0'
spec.add_development_dependency 'rspec', '~> 3.9'
spec.add_development_dependency 'rubocop', '~> 0.54.0'
spec.add_dependency 'openstudio-extension', '~> 0.3.1'
spec.add_dependency 'openstudio-standards', '~> 0.2.12'

@jmarrec
Copy link
Contributor Author

jmarrec commented Jun 3, 2021

required_ruby_version is outdated.

openstudio-extension and openstudio-standards too. bottom line is that this one should be kept up to date with the root one.

@macumber
Copy link
Contributor

macumber commented Nov 11, 2021

Just hit this today. The versions are generally too restrictive, suggest being pessimistic on the major version ~> 2.5 instead of the minor one ~>2.5.1 for OpenStudio gems. Here is what I ended up with:

  spec.required_ruby_version = '~> 2.5'

  spec.add_development_dependency 'bundler', '~> 2.1'
  spec.add_development_dependency 'rake', '~> 13.0'
  spec.add_development_dependency 'rspec', '~> 3.9'
  spec.add_development_dependency 'rubocop', '~> 1.15'
  spec.add_development_dependency 'openstudio_measure_tester', '~> 0.3'

  spec.add_dependency 'openstudio-extension', '~> 0.5'

I also think it is a good idea to remove the dependency on openstudio-standards since that is pretty heavy. Alternatively you could put openstudio-standards, openstudio-workflow, bcl, etc in but comment them out with a note like "If you want to run simulations, uncomment below". Then if people want to use them they can just comment them out.

@DavidGoldwasser
Copy link
Contributor

@nllong and @kflemin I will flag this for 3.5 release, but wanted to check with both of you to see what is needed to be in sync with measure gems and other tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

5 participants