Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] clang-format is tripping #5330

Closed
jmarrec opened this issue Dec 19, 2024 · 0 comments · Fixed by #5331
Closed

[CI] clang-format is tripping #5330

jmarrec opened this issue Dec 19, 2024 · 0 comments · Fixed by #5331
Assignees
@jmarrec
Labels
Developer Issue severity - Major Bug

Comments

@jmarrec
Copy link
Collaborator

jmarrec commented Dec 19, 2024

Issue overview

clang-format got bumped from 14 to 18 due to GHA image update (about a month ago I think), and as a result the clang-format often returns false positives right now

Possible Solution

Reformat entire codebase with clang-format-18

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version): all
  • Version of OpenStudio (if using an intermediate build, include SHA): 10eb60d
@jmarrec jmarrec self-assigned this Dec 19, 2024
@jmarrec jmarrec mentioned this issue Dec 19, 2024
Merged
8 tasks
jmarrec added a commit that referenced this issue Dec 19, 2024
@jmarrec
Merge pull request #5331 from NREL/clang-format
f3ca5f7 
Fix #5330 - Clang format: run for entire codebase on push to develop and commit autocorrects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmarrec jmarrec

Labels
Developer Issue severity - Major Bug
Projects
None yet
Milestone
No milestone
1 participant
@jmarrec