Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove check for zip file size from workflow #5274

Closed
DavidGoldwasser opened this issue Oct 16, 2024 · 1 comment · Fixed by #5275
Closed

Remove check for zip file size from workflow #5274

DavidGoldwasser opened this issue Oct 16, 2024 · 1 comment · Fixed by #5275
Assignees
@DavidGoldwasser
Labels
component - Workflow severity - Major Bug
Milestone
OpenStudio SDK 3.9.0

Comments

@DavidGoldwasser
Copy link
Collaborator

(https://github.com/NREL/OpenStudio/blob/develop/src/workflow/Util.cpp#L270)

@wenyikuang this could be good one for you to work on or @joseph-robertson could do it,. Would be great if we can get this in 3.9. I'll add to project and milestone.

CC @brianlball
@DavidGoldwasser DavidGoldwasser added Enhancement Request Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Oct 16, 2024
@DavidGoldwasser DavidGoldwasser added this to the OpenStudio SDK 3.9.0 milestone Oct 16, 2024
@DavidGoldwasser DavidGoldwasser added severity - Major Bug component - Workflow and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed Enhancement Request labels Oct 16, 2024
@DavidGoldwasser
Copy link
Collaborator Author

Maybe also delete this https://github.com/NREL/OpenStudio/blob/develop/src/workflow/Util.cpp#L283

@DavidGoldwasser DavidGoldwasser self-assigned this Oct 17, 2024
@DavidGoldwasser DavidGoldwasser mentioned this issue Oct 18, 2024
Merged
10 tasks
jmarrec added a commit that referenced this issue Oct 30, 2024
@jmarrec
Merge pull request #5275 from NREL/issue-5274-remove-zip-size-limits
cae9435 
Fix #5274 - workflow should not remove contents from zip because of size limit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavidGoldwasser DavidGoldwasser

Labels
component - Workflow severity - Major Bug
Projects
None yet
Milestone
OpenStudio SDK 3.9.0
Development

Successfully merging a pull request may close this issue.

Fix #5274 - workflow should not remove contents from zip because of size limit NREL/OpenStudio
1 participant
@DavidGoldwasser