Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behavior of runner.getArgumentValues() #5174

Closed
joseph-robertson opened this issue Apr 30, 2024 · 1 comment · Fixed by #5176
Closed

Unexpected behavior of runner.getArgumentValues() #5174

joseph-robertson opened this issue Apr 30, 2024 · 1 comment · Fixed by #5176

Comments

@joseph-robertson
Copy link
Collaborator

Issue overview

The args hash looks different when replacing OsLib_HelperMethods.createRunVariables with runner.getArgumentValues.

Current Behavior

When calling args = runner.getArgumentValues(arguments(model), user_arguments), a nil is returned for any keys that are in arguments(model) but not in user_arguments.

Expected Behavior

If the script argument has a default value set, then args should at least return the default value for that key. (?)

Steps to Reproduce

Run this measure test for add_rooftop_pv using v3.8.0-rc1, replacing OsLib_HelperMethods.createRunVariables(...) with runner.getArgumentValues(...).

Possible Solution

Details

Related to #5135.

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version):
  • Version of OpenStudio (if using an intermediate build, include SHA):

Context

@joseph-robertson joseph-robertson added the Triage Issue needs to be assessed and labeled, further information on reported might be needed label Apr 30, 2024
@joseph-robertson
Copy link
Collaborator Author

Is m_value here supposed to be m_defaultValue?

@joseph-robertson joseph-robertson added severity - Normal Bug and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels May 1, 2024
@joseph-robertson joseph-robertson added this to the OpenStudio SDK 3.8.0 milestone May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant