Support undisturbed ground temperature models on GroundHeatExchangerVertical #4932
Conversation
joseph-robertson
added
Enhancement Request
component - Model
Pull Request - Ready for CI
|
|
||
| if ((value = modelObject.groundThermalHeatCapacity())) { |
There was a problem hiding this comment.
What happens to these fields if they are set on the GroundHeatExchangerVertical system? If looks like they might be ignored. Maybe the implementation of these methods like GroundHeatExchangerVertical::groundThermalHeatCapacity() should map to the contained ground temperature model?
There was a problem hiding this comment.
ghxVert.groundThermalConductivity() and ghxVert.groundThermalHeatCapacity() both still get translated above.
ghxVert.groundTemperature() previously was only translated to the groundTempModel. AverageSoilSurfaceTemperature for the kusuda object is now handled by its own averageSoilSurfaceTemperature() method.
This is basically the same approach we used for the HorizontalTrench implementation - the ghxVert gets the soilThermalConductivity() and soilSpecificHeat, and then kusuda FTs its own averageSoilSurfaceTemperature().
There was a problem hiding this comment.
sorry missed the above. Got it.
| EXPECT_TRUE(ghx.setBoreHoleLength(80.0)); | ||
| EXPECT_TRUE(ghx.setBoreHoleRadius(0.7E-01)); | ||
| EXPECT_TRUE(ghx.setGroundThermalConductivity(0.7)); | ||
| EXPECT_TRUE(ghx.setGroundThermalHeatCapacity(0.3E+07)); |
There was a problem hiding this comment.
Like I mentioned. Do these methods do anything now?
There was a problem hiding this comment.
These 2 still translate to the ghxVert object (see explanation above).
|
CI Results for c10e1b7:
|
| @@ -78,6 +78,9 @@ You can also refer to the [OpenStudio SDK Python Binding Version Compatibility M | |||
| * Fix #4695 - AirLoopHVACUnitarySystem: Supply Air Flow Rate Method During <XXX> Operation should be set via related setters/autosize | |||
| * Breaks the return of `supplyAirFlowRateMethodDuringCoolingOperation` and `supplyAirFlowRateMethodDuringHeatingOperation`: now returns `std::string` instead of `boost::optional<std::string>` | |||
| * Deprecates many set/reset methods | |||
| * [#4932](https://github.com/NREL/OpenStudio/pull/4932) - Support undisturbed ground temperature models on GroundHeatExchangerVertical | |||
| * Fix #4930 - Support undisturbed ground temperature models on GroundHeatExchangerVertical | |||
| * Update `GroundHeatExchanger:Vertical` to actually use the Ground Temeprature Model field | |||
There was a problem hiding this comment.
Reminder to fix spelling of "Temeprature". (This was copied from the 3.6.0 release notes where it is misspelled.)
Pull request overview
Fixes #4930.
Checklist:
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.