Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap OutputControl:Timestamp #4808

Merged
merged 14 commits into from
Mar 16, 2023
Merged

Wrap OutputControl:Timestamp #4808

merged 14 commits into from
Mar 16, 2023

Conversation

joseph-robertson
Copy link
Collaborator

@joseph-robertson joseph-robertson commented Mar 1, 2023 •
edited
Loading

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources:
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@joseph-robertson joseph-robertson added component - Model Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. labels Mar 1, 2023
@joseph-robertson joseph-robertson self-assigned this Mar 1, 2023
@joseph-robertson joseph-robertson mentioned this pull request Mar 2, 2023
Closed
5 tasks
Base automatically changed from v23.1.0-IOFreeze to develop March 7, 2023 14:50
jmarrec
jmarrec requested changes Mar 7, 2023
View reviewed changes
Copy link
Collaborator

@jmarrec jmarrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes, otherwise this looks pretty good to me, even if this is still marked as a draft

src/model/OutputControlTimestamp.hpp Show resolved Hide resolved
src/model/OutputControlTimestamp_Impl.hpp Outdated Show resolved Hide resolved
src/model/OutputControlTimestamp.hpp Outdated Show resolved Hide resolved
resources/model/OpenStudio.idd Show resolved Hide resolved
resources/model/OpenStudio.idd Show resolved Hide resolved
@joseph-robertson joseph-robertson marked this pull request as ready for review March 7, 2023 15:07
jmarrec
jmarrec reviewed Mar 8, 2023
View reviewed changes
Copy link
Collaborator

@jmarrec jmarrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo when renaming

src/model/OutputControlTimestamp.cpp Outdated Show resolved Hide resolved
@shorowit shorowit mentioned this pull request Mar 8, 2023
Merged
7 tasks
jmarrec
jmarrec requested changes Mar 16, 2023
View reviewed changes
src/model/ModelSimulation.i Outdated Show resolved Hide resolved
@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Mar 16, 2023 •
edited
Loading

CI Results for fd45874:

@jmarrec
Copy link
Collaborator

jmarrec commented Mar 16, 2023

I'm pretty sure the csharp will work fine with my latest changes, and I don't want to wait 24 hours for windows to catch up with the build queue, so I'm going to merge. i'll hotfix the c# bindings on develop if I see it failing.

@jmarrec jmarrec merged commit 15d2f51 into develop Mar 16, 2023
@jmarrec jmarrec deleted the output-control-ts branch March 16, 2023 10:11
jmarrec added a commit that referenced this pull request Mar 16, 2023
@jmarrec
Hotfix #4808 - missing ignore in csharp bindings for OutputControlTim…
907a168 
…estamp
jmarrec
jmarrec reviewed Mar 16, 2023
View reviewed changes
src/model/ModelSimulation.i
Comment on lines +219 to +221
boost::optional<OutputControlTimestamp> outputControlTimestamp(const openstudio::model::Model& model) {
return model.outputControlTimestamp();
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize there needs to be an %ignore in ModelCore.i

jmarrec added a commit that referenced this pull request Mar 16, 2023
@jmarrec
Hotfix #4808 - missing ignore in csharp bindings for OutputControlTim…
e432743 
…estamp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmarrec jmarrec jmarrec requested changes

Assignees

@joseph-robertson joseph-robertson

Labels
component - Model Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E+ 23.1.0: Wrap OutputControl:Timestamp
3 participants
@joseph-robertson @ci-commercialbuildings @jmarrec