Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realign IDD for CoolingTower:SingleSpeed with E+ IDD #3650

Open
kbenne opened this issue Aug 31, 2019 · 2 comments
Open

Realign IDD for CoolingTower:SingleSpeed with E+ IDD #3650

kbenne opened this issue Aug 31, 2019 · 2 comments
Assignees

Comments

@kbenne
Copy link
Contributor

kbenne commented Aug 31, 2019

The best way to handle this and all name changes is to add a synonym method and mark the old one deprecated. I think no change is good enough for this one though. Need to at least update the idd translator but that is probably already done if the code is compiling

@kbenne kbenne added this to the OpenStudio 2.9.0 milestone Aug 31, 2019
@jmarrec
Copy link
Collaborator

jmarrec commented Sep 3, 2019

Cooling:Tower:SingleSpeed is falling pretty out of sync with the E+ Idd.

  • Lots of field name changes (including some that weren't introduced in 9.1.0 to 9.2.0).
  • Fields are in a fairly arbitrary order: I figure this was done to avoid having to write VersionTranslator but it makes it pretty hard to do a diff.
  • Lots of fields in E+ are correctly marked as \autocalculatable, but in OpenStudio they are marked \autosizable
  • It's missing the "Supply Water Storage Tank Name" field.

I think it would be good to realign the IDD with E+, I don't think it's critical for this release. I would actually consider doing it for 3.0.0 and just break the API (I would still write VersionTranslator rules to maintain forward compatibility in models of course).

jmarrec added a commit to jmarrec/OpenStudio that referenced this issue Sep 3, 2019
@jmarrec
Copy link
Collaborator

jmarrec commented Sep 3, 2019

Saving some progress in https://github.com/jmarrec/OpenStudio/tree/3650_Realign_CoolingTowerSingleSpeed and removing the 2.9.0 milestone from this one + re-titling.

@jmarrec jmarrec changed the title E+ Change: CoolingTower:SingleSpeed Realign IDD for CoolingTower:SingleSpeed with E+ IDD Sep 3, 2019
@jmarrec jmarrec removed this from the OpenStudio 2.9.0 milestone Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants