[7주차/필수] XML repository 패턴 #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaeulzzang
approved these changes
Jun 9, 2024
Comment on lines
+7
to
+30
| class SharedPrefDataSourceImpl @Inject constructor( | ||
| private val sharedPreferences: SharedPreferences | ||
| ) : SharedPrefDataSource { | ||
|
|
||
| override fun setUserId(key: String, value: Int) { | ||
| return sharedPreferences.edit().putInt(key, value).apply() | ||
| } | ||
|
|
||
| override fun getUserId(key: String): Int { | ||
| return sharedPreferences.getInt(key, 0) | ||
| } | ||
|
|
||
| override fun getBoolean(key: String): Boolean { | ||
| return sharedPreferences.getBoolean(key, false) | ||
| } | ||
|
|
||
| override fun setBoolean(key: String, value: Boolean) { | ||
| sharedPreferences.edit().putBoolean(key, value).apply() | ||
| } | ||
|
|
||
| override fun clearUserData() { | ||
| sharedPreferences.edit().clear().apply() | ||
| } | ||
| } |
| @@ -46,8 +42,7 @@ class MainFragment : Fragment() { | |||
|
|
|||
| initFloatingBtnClickListener() | |||
| initAdapter() | |||
| viewModel.getFriend() | |||
| FriendListObserver() | |||
| initFriendListObserver() | |||
yskim6772
approved these changes
Jun 9, 2024
Comment on lines
+13
to
+27
| @Module | ||
| @InstallIn(SingletonComponent::class) | ||
| abstract class RepositoryModule { | ||
| @Singleton | ||
| @Binds | ||
| abstract fun bindsFriendRepository( | ||
| friendRepository: FriendRepositoryImpl | ||
| ): FriendRepository | ||
|
|
||
| @Singleton | ||
| @Binds | ||
| abstract fun bindsSharedPrefRepository( | ||
| sharedPrefRepository: SharedPrefRepositoryImpl | ||
| ): SharedPrefRepository | ||
| } |
There was a problem hiding this comment.
우왕 Dagger-Hilt Module 사용 신기하네요 .... 굿굿 !!
Comment on lines
+120
to
+126
| is UiState.Failure -> { | ||
| Toast.makeText(requireContext(), "친구없음", Toast.LENGTH_SHORT).show() | ||
| } | ||
|
|
||
| is UiState.Empty -> { | ||
| Toast.makeText(requireContext(), "친구없음", Toast.LENGTH_SHORT).show() | ||
| } |
Comment on lines
+6
to
+9
| suspend fun insertFriend(friendEntity: FriendEntity) | ||
| suspend fun getFriend(): List<FriendEntity> | ||
| suspend fun deleteFriend(id:Int) | ||
| suspend fun deleteAll() |
Comment on lines
+3
to
+13
| sealed interface UiState<out T> { | ||
| object Empty : UiState<Nothing> | ||
| data class Success<T>( | ||
| val data: T | ||
| ) : UiState<T> | ||
|
|
||
| data class Failure( | ||
| val msg: String | ||
| ) : UiState<Nothing> | ||
|
|
||
| } |
There was a problem hiding this comment.
오 저도 UiState에 empty도 추가하는 등 보완해봐야겠네요 !! 👍
Comment on lines
+7
to
+30
| class SharedPrefDataSourceImpl @Inject constructor( | ||
| private val sharedPreferences: SharedPreferences | ||
| ) : SharedPrefDataSource { | ||
|
|
||
| override fun setUserId(key: String, value: Int) { | ||
| return sharedPreferences.edit().putInt(key, value).apply() | ||
| } | ||
|
|
||
| override fun getUserId(key: String): Int { | ||
| return sharedPreferences.getInt(key, 0) | ||
| } | ||
|
|
||
| override fun getBoolean(key: String): Boolean { | ||
| return sharedPreferences.getBoolean(key, false) | ||
| } | ||
|
|
||
| override fun setBoolean(key: String, value: Boolean) { | ||
| sharedPreferences.edit().putBoolean(key, value).apply() | ||
| } | ||
|
|
||
| override fun clearUserData() { | ||
| sharedPreferences.edit().clear().apply() | ||
| } | ||
| } |
jihyunniiii
approved these changes
Jun 9, 2024
|
|
||
| interface FriendDataSource { | ||
| suspend fun insertFriend(friendEntity: FriendEntity) | ||
| suspend fun getFriend(): List<FriendEntity> |
There was a problem hiding this comment.
리스트를 가져오니까 getFriends 라는 네이밍을 사용하는 게 더 좋을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
To Reviewers 📢