Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify max_fields_per_file via diag_manager namelist? #747

Closed
menzel-gfdl opened this issue May 13, 2021 · 2 comments · May be fixed by #750
Closed

Modify max_fields_per_file via diag_manager namelist? #747

menzel-gfdl opened this issue May 13, 2021 · 2 comments · May be fixed by #750
Assignees
@thomas-robinson @menzel-gfdl
Labels
enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality. feature request

Comments

@menzel-gfdl
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
The maximum number of variables allowed in a history file is controlled by:

FMS/diag_manager/diag_data.F90

Line 124 in 9d55115

INTEGER, PARAMETER :: MAX_FIELDS_PER_FILE = 300 !< Maximum number of fields per file.

If I'm not mistaken, diagnostics are limited to 4D (lon, lat, z, time). I am working on updates to the radiation code that require an additional spectral dimension. The work-around right now is to create one variable per spectral point, but this leads a very large number of variables and sometimes exceeds the hard limit set in the code above. Unfortunately this limit is a compile-time constant, so if you want to change it you must recompile. Can this instead be a run-time parameter accessible via the diag_manager_nml namelist?

Describe the solution you'd like
Remove the parameter attribute and add this variable to the diag_manager_nml namelist.

Describe alternatives you've considered
Ideally allow 5D (and possible more) diagnostics, but I know that given the current state of the modules this is not feasible.
@menzel-gfdl menzel-gfdl added the enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality. label May 13, 2021
@thomas-robinson thomas-robinson added this to To do in 2021.03 via automation May 17, 2021
@thomas-robinson thomas-robinson added this to the 2021.03 milestone May 17, 2021
@thomas-robinson thomas-robinson mentioned this issue May 20, 2021
Draft
8 tasks
@rem1776 rem1776 removed this from To do in 2021.03 Aug 5, 2021
@rem1776 rem1776 added this to To do in 2021.04 via automation Aug 5, 2021
@rem1776 rem1776 removed this from To do in 2021.04 Dec 23, 2021
@rem1776 rem1776 removed this from the 2021.03 milestone Jan 19, 2022
@rem1776
Copy link
Contributor

rem1776 commented Mar 3, 2022

@menzel-gfdl Do you still need this change in the diag_manager? The issue will be addressed in the rewrite but that will take some time, so we can add this in the meantime if needed.

@uramirez8707 uramirez8707 mentioned this issue Nov 2, 2023
Merged
8 tasks
@uramirez8707
Copy link
Contributor

Fixed in #1505

The modern diag manager no longer has any limits in the number of fields per file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomas-robinson thomas-robinson

@menzel-gfdl menzel-gfdl

Labels
enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality. feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Makes MAX_FIELDS_PER_FILE a namelist variable and allocates thomas-robinson/FMS
4 participants
@thomas-robinson @rem1776 @menzel-gfdl @uramirez8707