change compiler check and string indices for gcc #1529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am testing this in our regression suite. I will update soon to let you know if it works. |
|
I had not realized how much had been dropped from 2024.01. Unfortunately this will take longer than I had hoped to verify that things are working with I will update when I can, but it will take a while... |
|
closing since this breaks calls with the nvidia compiler and is a regression from past gcc versions, more details are in the linked issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
some small changes for the newest gcc
this gets the code passing the configure check and compiling successfully.
We may just want to get rid of the m4 i modified, so making this a draft for now.
Fixes #1527
How Has This Been Tested?
draft
Checklist:
make distcheckpasses