Parser: Add ability to read in generic blocks #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uramirez8707
commented
May 14, 2024
Comment on lines
+68
to
+71
| allocate(block_ids(get_num_unique_blocks(yaml_id, parent_block_id=varlist_ids(k)))) | ||
| call get_unique_block_ids(yaml_id, block_ids, parent_block_id=varlist_ids(k)) | ||
| do l = 1, size(block_ids) | ||
| call get_block_name(yaml_id, block_ids(l), block_name) |
There was a problem hiding this comment.
@J-Lentz @GFDL-Eric
This is relevant code that will be used to read the new field_table yaml format.
get_num_unique_blocks is going to be used to get the number of unique blocks for each variable. For the example below, it will get 1 for sphum and 2 for soa. get_unique_block_ids will be used to get an id for each of the blocks and that can be used to get the block name (i.e profile_type for sphum, and chem_param and profile_type for soa) and from there, it can be read as normal ...
field_table:
- field_type: tracer
modlist:
- model_type: atmos_mod
varlist:
- variable: sphum
longname: specific humidity
units: kg/kg
profile_type:
- value: fixed
surface_value: 3.0e-06
- variable: soa
longname: SOA tracer
units: mmr
convection: all
chem_param:
- value: aerosol
profile_type:
- value: fixed
surface_value: 1.0e-32
4 tasks
uramirez8707
requested review from
bensonr,
thomas-robinson and
rem1776
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include a summary of the change and which issue is fixed. Please also include
relevant motivation and context. List any dependencies that are required for
this change.
Fixes #1520
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.
Checklist:
make distcheckpasses