Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ozone_sonder name #345

Open
rschwant opened this issue Mar 10, 2025 · 9 comments
Open

Change ozone_sonder name #345

rschwant opened this issue Mar 10, 2025 · 9 comments
Labels
enhancement New feature or request

Comments

@rschwant
Copy link
Collaborator

Change the option for "ozone_sonder" to "ozone_sonde".

  • Need to update docs
  • Need to update driver
  • Need to update examples
  • Need to update doc examples
  • Maybe grep to make sure found all the places
@rschwant rschwant added the enhancement New feature or request label Mar 10, 2025
@rschwant rschwant moved this to Todo in MELODIES MONET Mar 10, 2025
@zmoon
Copy link
Collaborator

zmoon commented Mar 10, 2025

What about just "sonde"? Or something like "inst_sonde" to emphasize that these data are provided as each profile being just one time and fixed horizontal location

@rschwant
Copy link
Collaborator Author

I like using "sonde" here to make it more general. I put this as the interpolation. Is this right? Are you not interpolating on time here?

Ozonesonde - time and vertical interpolation at a fixed horizontal location

@zmoon
Copy link
Collaborator

zmoon commented Mar 10, 2025

I believe the model is interpolated to the time of the sonde.

I like using "sonde" here to make it more general.

I like the idea too, I'm not sure if what we currently have there would work with more general sonde data (which might have GPS position and data varying in time for a given sounding). But for that sort of sounding, you might want to use the aircraft option anyway. Has anyone tried that?

@btang1
Copy link
Contributor

btang1 commented Mar 10, 2025

when I code the ozone sonder, we interpolate time, that is why we need nearest 2 time step for ozone sonde code.

for vertical interpolation, I use the one in aircraft code.

for horizontal interpolation, no we assume fix lat and lon at starting point.

@rschwant
Copy link
Collaborator Author

Do you interpolate the time to one fixed time for the entire profile or allow the time to vary as the sonde moves along it's trajectory?

@btang1
Copy link
Contributor

btang1 commented Mar 10, 2025

I think I interpolated to fixed time, the release time/start time.

@rschwant
Copy link
Collaborator Author

Can you verify this to be sure and if so, I'll update the description so this is clearer to users, thanks!

@btang1
Copy link
Contributor

btang1 commented Mar 10, 2025

SURE!

@btang1
Copy link
Contributor

btang1 commented Mar 11, 2025

@rschwant @zmoon

ozone sonder time interpolation based on release time in the observation
code: ds_model = ds_model.interp(time=ds_model.time_obs.squeeze())
p.s. time is release time, only 1 time.

vertical interpolation use aircraft vertical interpolation:
code: paired_data = vert_interp(ds_model,obs.obj,keys+mod_vars)

horizontal interpolation use nearest neighbor, ignore horizontal displacement while sonder flew bottom to top.
code: ds_model = m.util.combinetool.combine_da_to_da(model_obj,new_ds_obs,merge=False)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

3 participants