Region support only works with obs Dataframes

[blychs]

Dear all,
Currently, the region support that works with AirNow does not work for everything else the way it should.
The code is reading regions from the information already provided by the obs DataFrame (the driver does a query. However, with EPA and Giorgi regions there is no reason for that: we have boxes defined in MONET, that MONETIO can import.
The sat data with the current setup just wouldn't work for any domain_type different from 'all' (I don't know about aircraft).
If @rschwant and @rrbuchholz agree, I suggest changing it (for now, I could stick to the satdata for that) so that it can subset the domain, at least in the case of EPA and Giorgi regions. Adding arbitrary square boxes should be close to no extra effort.
We can mention this in the tutorial as WIP.
Let me know your thoughts
Pablo

[rschwant]

The domains being based on a query is still useful though. Because the surface observations normally have meta data to separate out the domains, so I do not want to change this feature. As you can easily plot based on state, city, etc. this way. The boxes in MONET and MONETIO I doubt are as accurate as they would be based on lat lon boxes that may not perfectly represent the domain. But adding the capability to use domains for data that does not provide meta data for this would be useful. But we need to do it in a way that does not break the query feature for surface observations. Can we add a yaml true/false statement for this? Something like domain_query = True (default and domains are based on the meta data in the observation file) and if you set this to False, then it uses the boxes defined in MONET and MONETIO to do this query. What do you think about this?

[blychs]

That is a good solution. I am happy to move forward with that, or at least adding an extra check for the satdata.

[rschwant]

Great thanks!

[blychs]

Closing this as it has been solved in #280