-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add preview functionality to PRs #338
Comments
I setup netlify for PRs in one of my repos see for example i-VRESSE/workflow-builder#169 . I am using the Open Source team plan. Bad thing about Netlify is that they do not have bandwidth or build time limits, they will charge you if you go over your plan limit. So maybe another service is better. |
Maybe we can use this? https://github.com/rossjrw/pr-preview-action |
I looked into that one, but my impression is that it commits all the previews to your default git branch, which doesn't seem desirable to me. |
If I'm not mistaken, Netlify now no longer charges you when you go over limits: https://www.netlify.com/blog/introducing-netlify-free-plan At least I didn't fill out any billing information... |
Indeed, I think with the new plans this is no longer an issue @sverhoeven, see: |
Currently, contributors (and reviewers) are advised to spin up a webserver locally to check out whether their changes render properly. Obviously, nobody does this. I have seen other repos automatically spin up a netlify or similar free server to create a preview of the website and link to it in the PR. For the Guide, I think this could be done even simpler, because the Guide is static content, it doesn't need a complicated webserver. Anybody have ideas of how to make this happen? I think it would greatly smoothen the contribution process and improve reviews (surely my own, because I'm only now noticing rendering errors in #328 😉).
The text was updated successfully, but these errors were encountered: