[feature/PI-650] Read as device #425
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslinnell
force-pushed
the
feature/PI-650-read_as_device
branch
5 times, most recently
from
4188a8d
to
1c21964
Compare
megan-bower4
changed the base branch from
main
to
feature/PI-572-create_an_as_device
AS Device read feature tests
Update tests
jameslinnell
force-pushed
the
feature/PI-650-read_as_device
branch
from
1c21964
to
b4ed41a
Compare
Comment on lines
+84
to
+93
| for key, filters in device.device_reference_data.items(): | ||
| for drd in device_reference_data_list: | ||
| if str(drd.id) == key: | ||
| for responses in drd.questionnaire_responses.values(): | ||
| for qresponse in responses: | ||
| if "*" not in filters: | ||
| qresponse.data = { | ||
| filter_key: qresponse.data[filter_key] | ||
| for filter_key in filters | ||
| } |
There was a problem hiding this comment.
This is very heavily nested - although I've tried to look at it but not sure how to make it any simpler either, unless some of the logic is pulled out into a separate function for readability at least? Don't know if Joel would have any magic python ideas for this? He's improved a lot of my if statements/for loops before :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.