Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 19 Support #8890

Open
markpritchett opened this issue Nov 22, 2024 · 10 comments
Open

Angular 19 Support #8890

markpritchett opened this issue Nov 22, 2024 · 10 comments
Labels
✅ DONE Feature Request is done
Milestone

Comments

@markpritchett
Copy link

What problem does this feature solve?

Allows users to migrate to Angular 19

What does the proposed API look like?

Upgrade dependencies to enable users to migrate to Angular 19.

PR merged for @ant-design/icons-angular package chore: bump icons-angular to v19 but it seems we waiting for NPM package to be published

@Laffery Laffery added this to the v19 milestone Nov 25, 2024
@Laffery
Copy link
Collaborator

Laffery commented Nov 25, 2024

npm package for @ant-design/icons-angular v19 has been published today.

ng-zorro-antd@19 is on the way, we are planning to publish a beta version this week.

@Laffery Laffery pinned this issue Nov 25, 2024
@azimtechie
Copy link

npm package for @ant-design/icons-angular v19 has been published today.

ng-zorro-antd@19 is on the way, we are planning to publish a beta version this week.

Any update on this ? because we are starting new project with angular 19 and we really need to ng-zorro in our project

@Laffery
Copy link
Collaborator

Laffery commented Dec 2, 2024

There are two important feature PRs still in progress #8901 #8903

@dylanvdmerwe
Copy link

These two PRs have nothing to do with Angular 19 though? Why would these block the support of 19?

@markpritchett
Copy link
Author

These two PRs have nothing to do with Angular 19 though? Why would these block the support of 19

@dylanvdmerwe It's likely to be because those 2 PRs are part of v19 Milestone and since at least one of these PRs contains breaking changes, it will be better to include it with Angular upgrade otherwise the team wouldn't have the opportunity to introduce breaking changes until v20, most likely due out after Angular v20.

@ext-dflopes
Copy link

ext-dflopes commented Dec 4, 2024

image
Yeah! We're almost there! My frontend team is joining me next week, and I’m pumped to have Angular 19 ready in the architecture for their arrival. Let’s keep up the amazing work!

@Laffery
Copy link
Collaborator

Laffery commented Dec 6, 2024

👋 Hey everyone!

[email protected] is available, welcome to upgrade to the beta version and have a try by executing

We've brought in a lot of new features in v19, please refer to release note to learn more! Thanks to all the developers in the community who have contributed so much to it!

Looking forward to your kindly feedback, which is really important to us.

Best,
NG ZORRO team

@Laffery
Copy link
Collaborator

Laffery commented Dec 6, 2024

For people who are using ng update to upgrade and encounter the following errors

An unhandled exception occurred: Cannot find module '@angular-devkit/core'
Require stack:
- /path/to/node_modules/@angular/cdk/schematics/utils/build-component.js
- /path/to/node_modules/@angular/cdk/schematics/utils/index.js
- /path/to/node_modules/@angular/cdk/schematics/index.js
- /path/to/node_modules/ng-zorro-antd/schematics/ng-update/index.js
- /private/var/folders/wy/hks67dyn2t3856tggqh4zkkw0000gp/T/angular-cli-packages-o3eQSL/node_modules/@angular-devkit/schematics/tools/export-ref.js
- /private/var/folders/wy/hks67dyn2t3856tggqh4zkkw0000gp/T/angular-cli-packages-o3eQSL/node_modules/@angular-devkit/schematics/tools/index.js
- /private/var/folders/wy/hks67dyn2t3856tggqh4zkkw0000gp/T/angular-cli-packages-o3eQSL/node_modules/@angular/cli/src/commands/update/cli.js
- /private/var/folders/wy/hks67dyn2t3856tggqh4zkkw0000gp/T/angular-cli-packages-o3eQSL/node_modules/@angular/cli/src/commands/command-config.js
- /private/var/folders/wy/hks67dyn2t3856tggqh4zkkw0000gp/T/angular-cli-packages-o3eQSL/node_modules/@angular/cli/src/command-builder/command-runner.js
- /private/var/folders/wy/hks67dyn2t3856tggqh4zkkw0000gp/T/angular-cli-packages-o3eQSL/node_modules/@angular/cli/lib/cli/index.js
- /private/var/folders/wy/hks67dyn2t3856tggqh4zkkw0000gp/T/angular-cli-packages-o3eQSL/node_modules/@angular/cli/lib/init.js
See "/private/var/folders/wy/hks67dyn2t3856tggqh4zkkw0000gp/T/ng-eUtPGl/angular-errors.log" for further details.

Consider to add @angular-devkit/core to devDependencies explicitly and retry :)

@Laffery Laffery added the ✅ DONE Feature Request is done label Dec 6, 2024
@lppedd
Copy link
Contributor

lppedd commented Dec 6, 2024

@Laffery hey! The 19.0.0-beta.0 changelog says NzInputGroupComponent is deprecated, yet it's not marked as such in the code and I can't find the proposed alternative. Are you sure it's correct?

@Laffery
Copy link
Collaborator

Laffery commented Dec 6, 2024

@Laffery hey! The 19.0.0-beta.0 changelog says NzInputGroupComponent is deprecated, yet it's not marked as such in the code and I can't find the proposed alternative. Are you sure it's correct?

@lppedd hi! It's a mistake, what's really deprecated is its nzCompact input property, which can be replaced with new nz-space-compact component.

The release note is updated, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ DONE Feature Request is done
Projects
None yet
Development

No branches or pull requests

6 participants