Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove line profile from skimage activity in digital image basics module?! #650

Closed
tischi opened this issue Apr 25, 2024 · 5 comments · May be fixed by #652
Closed

remove line profile from skimage activity in digital image basics module?! #650

tischi opened this issue Apr 25, 2024 · 5 comments · May be fixed by #652
Labels

Comments

@tischi
Copy link
Collaborator

tischi commented Apr 25, 2024

I find this really disrupts the flow of teaching: https://github.com/NEUBIAS/training-resources/blob/master/_includes/pixels/pixels_act1_skimage_napari.py#L4

For trainers, they may only see this when they already told the students to open a jupyter notebook and then they have to close it again, which could be a mess.

My instinct would be to either remove the line profile here either entirely or add the installation of the napari plugin to the tool installation instructions.

What do you think @k-dominik @tibuch ?

@tischi
Copy link
Collaborator Author

tischi commented Apr 26, 2024

This may be a different story in later, more advance modules, but to already do some special stuff in the very first module is very likely a mental overload.

@k-dominik
Copy link
Collaborator

k-dominik commented Apr 26, 2024

I agree with the mental overload!
napari-plot-profile is also on conda-forge. I tested the installation and for me it works™️ (tested the plugin works, too). I'd be for adding it to the installation instructions.

@tischi
Copy link
Collaborator Author

tischi commented Apr 26, 2024

Great! Could you please do this?

For Monday, since I don't want the students now to reinstall their environment I will just skip the line profile part.

But for the next course we will then have it at our finger tips :-)

@k-dominik
Copy link
Collaborator

will do!

k-dominik added a commit that referenced this issue Apr 26, 2024
it is needed for `_includes/pixels/pixels_act1_skimage_napari.py`, which
previously required additional installation steps that we want to avoid
due to the this module being usually taught early in the course.

closes #650
k-dominik added a commit that referenced this issue Apr 26, 2024
it is needed for `_includes/pixels/pixels_act1_skimage_napari.py`, which
previously required additional installation steps that we want to avoid
due to the this module being usually taught early in the course.

closes #650
k-dominik added a commit that referenced this issue Apr 26, 2024
it is needed for `_includes/pixels/pixels_act1_skimage_napari.py`, which
previously required additional installation steps that we want to avoid
due to the this module being usually taught early in the course.

closes #650
k-dominik added a commit that referenced this issue Apr 26, 2024
it is needed for `_includes/pixels/pixels_act1_skimage_napari.py`, which
previously required additional installation steps that we want to avoid
due to the this module being usually taught early in the course.

closes #650
@tischi
Copy link
Collaborator Author

tischi commented Apr 29, 2024

Done.

@tischi tischi closed this as completed Apr 29, 2024
k-dominik added a commit that referenced this issue May 28, 2024
it is needed for `_includes/pixels/pixels_act1_skimage_napari.py`, which
previously required additional installation steps that we want to avoid
due to the this module being usually taught early in the course.

closes #650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants