Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import validation does not check for typos in taxonomy #100

Closed
dleehr opened this issue Dec 10, 2013 · 1 comment
Closed

Import validation does not check for typos in taxonomy #100

dleehr opened this issue Dec 10, 2013 · 1 comment

Comments

@dleehr
Copy link
Member

dleehr commented Dec 10, 2013

The import process was designed to ignore columns that are not named in the config. This allows us to ignore data that isn't relevant.

However, since the importer is only looking for specific names (e.g. "Kingdom" and not "kingdom"), this can cause the taxonomy to be incomplete (see #99) yet the import still appears successful.

This issue should be improved. The columns may need to be case-insensitive, or perhaps display a warning if all of the taxonomy represented by the config file is not found.

@dleehr
Copy link
Member Author

dleehr commented Dec 17, 2013

There are also issues where traits don't get imported and no warning is displayed. For example, Begonia.csv has a column for 'Sexual System (hermaphrodite,monoecy,dioecy,...)'. 'Sexual System' is listed in the import config but doesn't get imported.

Perhaps a simple warning step: These columns will not be imported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant