Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for UGRID versions greater than 1.0 #301

Open
sadielbartholomew opened this issue May 30, 2024 · 0 comments · May be fixed by #296
Open

Prepare for UGRID versions greater than 1.0 #301

sadielbartholomew opened this issue May 30, 2024 · 0 comments · May be fixed by #296
Assignees
Labels
bug Something isn't working code tidy/refactor UGRID Relating to UGRID mesh topologies

Comments

@sadielbartholomew
Copy link
Member

The code presently registers and stores any valid version ID (1.0, 2.10.4, 6.2.3, etc.) for the UGRID Conventions, but only processes any UGRID features with code supporting v1.0. This is probably harmless for now with v1.0 being the latest and greatest version (and that included in CF for the present CF, v1.11), but as-is the behaviour will be mis-leading for subsquent UGRID versions upon release. To be ready in case datasets are around ready/compliant for new UGRID releases, we should at least warn that the code is assuming and processing features according to UGRID v1.0.

As discussed offline. To be fixed in #296.

@sadielbartholomew sadielbartholomew added bug Something isn't working code tidy/refactor UGRID Relating to UGRID mesh topologies labels May 30, 2024
@sadielbartholomew sadielbartholomew self-assigned this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code tidy/refactor UGRID Relating to UGRID mesh topologies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant